143093 - Make progress window strings localizable

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Mike Pinkerton (not reading bugmail)]

Patch forthcoming, subject says it all.

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: hook it up

from David Haas.

I haven't yet tried it, but i eyeballed it. It looks complicated. Surely there
must be an easier way to do all this formatting. What about even writing our
own cocoa text formatter objects so we can re-use them elsewhere in the app if
need be?

Comment 2

[David Hyatt]

Joe, this may be useful to you when writing the download manager.  Maybe 
not. :)  Anyway, it shouldn't be checked in, since we're throwing this dialog 
out and replacing it with a download manager anyway.

Comment 3

[David Haas (gone, not reading mail)]

That far off scream of anguish you just heard was me reading that this dialog,
on which I've worked so hard, is getting thrown out.  And I had just made
another patch which hooked up the open, show, and cancel buttons, as well as a
couple more little fixes on the progress bar and status updates. 

Oh well, it's just a hobby. 

Comment 4

[Mike Pinkerton (not reading bugmail)]

lol, sorry david! ;)

Comment 5

[David Haas (gone, not reading mail)]

Attachment: it pretty much works.

Hey.

So I know hyatt already said there was no reason to check 
this code in since the whole dialog is going to be replaced
by a Download Manager, and I know that the initial patch 
was relatively convoluted , and I know lots of people
were complaining about the dialog violating UI guidelines, 
etc, etc, etc.

It just seems goofy to me to release builds with a half implemented
window when code exists to (mostly) finish things up.  That's why I've
submitted this patch.  Sure, it may still be messy, but the window's 
going to get thrown away eventually so big deal.  And even if it never
makes it into the normal builds, at least some enterprising individual
could patch their own build & use it until the download manager appears.

Now that I've said my peace, I'm going to eat some ice cream.

Comment 6

[Winnie Lam]

Related to 145800 - http://bugzilla.mozilla.org/show_bug.cgi?id=145800.

Should we resolve this bug as invalid per Haas's comment?

Comment 7

[saari (gone)]

->hewitt, is this still valid with your code?

Comment 8

[David Haas (gone, not reading mail)]

Attachment: fix

a few small fixes to the "it pretty much works" patch.	A couple of other bugs
are complaining about this dialog - I'll throw my opinion out one last time
that this patch should be applied until such time as the download manager
appears & renders this obsolete.  This patch requires slight modifications to
the ProgressDialog.nib file.

Comment 9

[David Haas (gone, not reading mail)]

Attachment: Nib file

zipped up nib file for "fix" patch.

Comment 10

[Mike Pinkerton (not reading bugmail)]

notes on latest patch...

- where is the AboutSec string key coming from? i don't see any attached
localized string file.
- i really don't think the user cares about that many steps in estimated time. I
think < 1 minute and < 10 seconds is plenty
- if possible, can you make any code you add/touch have 2 spaces per indent? i
know most of that file is at 4, but we really should move things to 2 spaces
when we're modifying large parts of the file

Comment 11

[David Haas (gone, not reading mail)]

Attachment: yet another fix

My response:

1.  D'oh!  I forgot to include it in the last revision.  My bad.
2.  You're probably right.  I left in < 5 sec, since the finder
    gives a "About 5 seconds" warning.	Feel free to cut it, though.
3.  Again, my bad.  I switched to 2 space indents awhile back, but 
    it didn't make it here.  That's fixed.  I may have accidentally
    also 2-spaced a couple of things I didn't change, so they'll show
    up in this patch too.  Sorry about that.

Comment 12

[David Haas (gone, not reading mail)]

One last thing.  Could some nice person with the power to obsolete patches go
through and obsolete "hook it up", "it pretty much works", and "fix"?  

Comment 13

[Mike Pinkerton (not reading bugmail)]

i added the strings file to the project, but it's not picking it up. ie, if i
change the strings, they always use the ones hardcoded in the source. what am i
doing wrong?

Comment 14

[Mike Pinkerton (not reading bugmail)]

i landed everything except the string file, which i couldn't figure out how to
hook up. can someone vend me a clue? i also removed the groupboxes from the
dialog. let's leave this open to figure out the string file, then we can close it.

Comment 15

[sairuh (rarely reading bugmail)]

filed bug 152629 as a companion to this, where the buttons are non-functional.

Comment 16

[David Haas (gone, not reading mail)]

Hey - have you figured out how to get the strings file working yet?  I think
you can do it the same way as in bug 148556, except mentally replace
"Localizable.strings" with "ProgressDialog.strings"

If you'd prefer, I'll submit a patch that'll make it read out of the
Localizable.strings file instead.  It's all cool with me.

Comment 17

[Mike Pinkerton (not reading bugmail)]

yeah, i figured it out. can you make a localized patch?

Comment 18

[David Haas (gone, not reading mail)]

Um, I can, if I can figure out what you're asking.

Do you want a patch that reads out of the localizable.strings file
instead of ProgressDialog.strings?  Or something else entirely?

Comment 19

[Mike Pinkerton (not reading bugmail)]

what is generally done with cocoa apps? are all localized strings in one file,
or does each component generally have its own string file?

Comment 20

[David Haas (gone, not reading mail)]

Hmmm.  I don't really know.  The best I could come up with was an Aaron
Hillegass quote: "Most simple apps only use localizable.strings."  

I guess I originally put things in ProgressDialog.strings because I thought the
whole dialog would disappear in a couple of revisions, and it would be easier to
remove the detrius if these strings were in their own little file.  

If nobody else jumps into this discussion with more of a clue than I have by
tonight, I'll make a patch to go into localizable.strings.

Comment 21

[David Haas (gone, not reading mail)]

Attachment: localized patch

localization patch (everything in localizable.strings)

Comment 22

[saari (gone)]

back to pinkerton

Comment 23

[Simon Fraser [no longer active]]

Update summary

Comment 24

[Mike Pinkerton (not reading bugmail)]

this patch doesn't apply any more, can you provide a new one? i'd like to get
this landed. also, the localizable.strings appears to be in unicode, and
everything is choking on it.

Comment 25

[Mike Pinkerton (not reading bugmail)]

never mind, codewarrior cleaned it up for me. checked in.

Comment 26

[Mike Pinkerton (not reading bugmail)]

v