152629 - download dlg: implement Pause, Close When Done, Open File

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[sairuh (rarely reading bugmail)]

i'm not sure bug 145800 covered these items thoroughly enough --also, this bug
could be viewed as a companion to bug 143093. i couldn't find an existing bug
that would cover these features, but do dup as needed!

in the download progress dlg, there are several buttons which currently
(2002.06.18.05) don't do anything when clicked:

* Cancel
* Pause/Resume
* Close When Done/Leave Open
* Show File
* Open File

Comment 1

[Mike Pinkerton (not reading bugmail)]

they all work for me (except pause) with my pull from this morning, though i did
land a patch that might have addressed this.

Comment 2

[sairuh (rarely reading bugmail)]

okay, i'll check it out with tomorrow's bits.

Comment 3

[sairuh (rarely reading bugmail)]

this is what i see using today's (2002.06.19.05) build:

* Cancel works
* Pause/Resume broken (already noted by pink)
* Close When Done/Leave Open still does nothing
* Show File works
* Open File still does nothing --could this be dependent another bug (helper app
issues)?

Comment 4

[saari (gone)]

if cancel and close work, this isn't a blocker. We might want to remove
pause/resume if it doesn't work though

Comment 5

[saari (gone)]

we should remove any non-functional buttons for now

Comment 6

[David Haas (gone, not reading mail)]

From 6.19.02 build:

the "open file" button for me opens a file.  At least when the
extension (definately) or type/creator code (i think) is known.
I use the nightly build page for my download tests, and everything
there seems to be picked up by Stuffit.  If you point me to a page
with a download of some obscure type, I'll check it out.

I'm 99% sure the "close when done/leave open" button used to work. i think i
might have accidentally broken it.  it'll take me a few days before
i can screw around with this again, tho.

Comment 7

[David Haas (gone, not reading mail)]

Attachment: fixes boo-boo

This patch does 2 useful things:

1) makes the "close when done"/"leave open" button work again.
2) fixes bug 152903: unable to save files.

And all by moving 1 statement up 4 lines in the code.

Comment 8

[saari (gone)]

Allright, let's get this in so we can fix the regression. Nice catch :-)

Comment 9

[saari (gone)]

This still needs to get landed, can someone r and sr please?

Comment 10

[saari (gone)]

Comment on attachment 88552 [details] [diff] [review]
fixes boo-boo

r=saari

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 88552 [details] [diff] [review]
fixes boo-boo

sr=sfraser

Comment 12

[Mike Pinkerton (not reading bugmail)]

landed

Comment 13

[Winnie Lam]

verified using 06-27 build on OS 10.1.5.

- Cancel works
- Close when done/Leave open works
- Show file works
- Open file works

Looks like Pause is permanently grayed out.  Could we remove it from the UI all
together since it's grayed out anyway?  (UI polish issue)  If it'll be a lot of
effort to remove it, then being grayed out is okay.

Leaving as Resolved Fixed for now.

Comment 14

[Winnie Lam]

Marking verified.  Reporting new bug to remove "Pause" from download dialog as a
polish issue.