1431027 - Disk space warning shows incorrect preferences path

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

The "storage pressure notification" (https://blog.nightly.mozilla.org/files/2017/07/storage_pressure_notification.png) still contains the old preference structure:

"You can clear stored site data in Preferences > Advanced > Site Data."

This should be updated. We'll probably do it as part of the storage UX improvements.

https://searchfox.org/mozilla-central/rev/48cbb200aa027a0a379b6004b6196a167344b865/browser/locales/en-US/chrome/browser/preferences/preferences.properties#217

Comment 1

[Nicole Yee (:nicoleyee)]

What do we want the warning to say?

Comment 2

[Jacqueline Savory [:jsavory] UX]

I think the correct path should sound something like this:

"You can clear stored data in Preferences > Privacy & Security > Cookies and Site Data"

Let me know if it works :)

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1431027 - Update disk space warning to reflect the latest preferences.

This changes the disk space notification to show the correct preferences path
and to use the correct openPreferences arguments.

Review commit: https://reviewboard.mozilla.org/r/222128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222128/

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8952894 [details]
Bug 1431027 - Update disk space warning to reflect the latest preferences.

https://reviewboard.mozilla.org/r/222128/#review228946

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 5dddf495f788802046431f505cfb11d00519cdcc -d 0c0eef1ad232: rebasing 448830:5dddf495f788 "Bug 1431027 - Update disk space warning to reflect the latest preferences. r=nhnt11" (tip)
merging browser/base/content/browser.js
merging browser/components/preferences/in-content/privacy.xul
warning: conflicts while merging browser/components/preferences/in-content/privacy.xul! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8952894 [details]
Bug 1431027 - Update disk space warning to reflect the latest preferences.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222128/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585f10df6350
Update disk space warning to reflect the latest preferences. r=nhnt11

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/585f10df6350