Closed Bug 1431027 Opened 3 years ago Closed 3 years ago

Disk space warning shows incorrect preferences path

Categories

(Firefox :: Preferences, enhancement, P1)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: johannh, Assigned: johannh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [storage-v2])

Attachments

(1 file)

The "storage pressure notification" (https://blog.nightly.mozilla.org/files/2017/07/storage_pressure_notification.png) still contains the old preference structure:

"You can clear stored site data in Preferences > Advanced > Site Data."

This should be updated. We'll probably do it as part of the storage UX improvements.

https://searchfox.org/mozilla-central/rev/48cbb200aa027a0a379b6004b6196a167344b865/browser/locales/en-US/chrome/browser/preferences/preferences.properties#217
Priority: -- → P2
Whiteboard: [storage-v2][triage] → [storage-v2]
What do we want the warning to say?
Flags: needinfo?(jsavory)
I think the correct path should sound something like this:

"You can clear stored data in Preferences > Privacy & Security > Cookies and Site Data"

Let me know if it works :)
Flags: needinfo?(jsavory)
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8952894 [details]
Bug 1431027 - Update disk space warning to reflect the latest preferences.

https://reviewboard.mozilla.org/r/222128/#review228946
Attachment #8952894 - Flags: review?(nhnt11) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 5dddf495f788802046431f505cfb11d00519cdcc -d 0c0eef1ad232: rebasing 448830:5dddf495f788 "Bug 1431027 - Update disk space warning to reflect the latest preferences. r=nhnt11" (tip)
merging browser/base/content/browser.js
merging browser/components/preferences/in-content/privacy.xul
warning: conflicts while merging browser/components/preferences/in-content/privacy.xul! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/585f10df6350
Update disk space warning to reflect the latest preferences. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/585f10df6350
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.