Closed Bug 1431109 Opened 2 years ago Closed 2 years ago

'*<unknown>.mozilla::StaticAutoPtr<mozilla::SandboxReporter>::mRawPtr' is used uninitialized in this function [-Werror=uninitialized]

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1430729 +++

There is a second occurrence
with gcc 8-20180110-1
 In file included from /root/firefox-gcc-last/security/sandbox/linux/reporter/SandboxReporter.h:13,
                  from /root/firefox-gcc-last/security/sandbox/linux/reporter/SandboxReporter.cpp:7:
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/StaticPtr.h: In constructor 'mozilla::StaticAutoPtr<T>::StaticAutoPtr() [with T = mozilla::SandboxReporter]':
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/StaticPtr.h:48:17: error: '*<unknown>.mozilla::StaticAutoPtr<mozilla::SandboxReporter>::mRawPtr' is used uninitialized in this function [-Werror=uninitialized]
      MOZ_ASSERT(!mRawPtr);
                  ^~~~~~~
 cc1plus: all warnings being treated as errors

Not sure if this is a bug in the compiler false positive or not.
Comment on attachment 8943276 [details]
Bug 1431109 - Ignore a second incorrect warning with gcc (-Wuninitialized)

https://reviewboard.mozilla.org/r/213600/#review219322

::: xpcom/base/StaticPtr.h:51
(Diff revision 1)
>    StaticAutoPtr()
>    {
> +#ifdef __GNUC__
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wuninitialized"
> +  // False positive with gcc. See bug 1430729

Do we want to reference the `StaticRefPtr` bug here, as written, or do we want to change this to reference this bug?  Either option makes sense, I think.
Attachment #8943276 - Flags: review?(nfroyd) → review+
I kept the same bug because it is the same issue at the end. When reading at the code, this will avoid the effect "why the same code has two different bugs? Maybe there is a good reason for that" :)
WFM!
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1edfd7219583
Ignore a second incorrect warning with gcc (-Wuninitialized) r=froydnj
https://hg.mozilla.org/mozilla-central/rev/1edfd7219583
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.