Closed Bug 1431320 Opened 2 years ago Closed 2 years ago
Extra top padding on some add-ons notification doorhangers
59 bytes, text/x-review-board-request
(In reply to Mark Striemer [:mstriemer] from bug 1369482 comment #37) > Created attachment 8943399 [details] [diff] [review] > 1369482-webext-regressions.patch > > This regressed the top padding on some add-ons notifications since they were > hiding the header based on the class and popupid. In the future they should > use this update to avoid having to do that, I'll file to bring it up to date. > > This also regressed the New Tab doorhanger you get when you install an > extension that sets the New Tab page. I'm also adding a similar doorhanger > for the home page which is what made me notice this. That code is setting > the popupnotification[label] which is now replaced with > startlabel,host,endlabel. > > Here's a patch that fixes the add-ons notifications and works with the > updates here. It instead replaces label with label,host,endlabel. This > should keep backwards compatibility with notifications that just want a > label. > > Johann, does this changeset look good to you?
Can we address the extra spaces (bug 1369482 comment 39) here? I think it would be a matter of putting all elements in <xul:description> on a single line in the markup
(In reply to Francesco Lodolo [:flod] from comment #2) > Can we address the extra spaces (bug 1369482 comment 39) here? I think it > would be a matter of putting all elements in <xul:description> on a single > line in the markup I think Prathiksha is looking into that and will file a new bug with a patch when she has a solution, keeping the issues separate sounds more appropriate (and in this case more efficient) to me (though I'd also review a patch in this bug if it has to be).
Comment on attachment 8943515 [details] [diff] [review] patch Review of attachment 8943515 [details] [diff] [review]: ----------------------------------------------------------------- r=me but you will also have to update https://searchfox.org/mozilla-central/source/browser/base/content/test/popupNotifications/head.js#207-213 to get all tests passing (and please do a try run afterwards). Thanks again for putting up a patch so quickly!
Attachment #8943515 - Flags: review?(jhofmann) → review+
Attachment #8943787 - Attachment is obsolete: true
Comment on attachment 8943788 [details] Bug 1431320 - Add support for label back to popupnotification https://reviewboard.mozilla.org/r/214170/#review219976 Thank you!
Attachment #8943788 - Flags: review?(jhofmann) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/332f7a698353 Add support for label back to popupnotification r=johannh
You need to log in before you can comment on or make changes to this bug.