Closed
Bug 1431320
Opened 6 years ago
Closed 6 years ago
Extra top padding on some add-ons notification doorhangers
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | fixed |
People
(Reporter: johannh, Assigned: mstriemer)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
(In reply to Mark Striemer [:mstriemer] from bug 1369482 comment #37) > Created attachment 8943399 [details] [diff] [review] > 1369482-webext-regressions.patch > > This regressed the top padding on some add-ons notifications since they were > hiding the header based on the class and popupid. In the future they should > use this update to avoid having to do that, I'll file to bring it up to date. > > This also regressed the New Tab doorhanger you get when you install an > extension that sets the New Tab page. I'm also adding a similar doorhanger > for the home page which is what made me notice this. That code is setting > the popupnotification[label] which is now replaced with > startlabel,host,endlabel. > > Here's a patch that fixes the add-ons notifications and works with the > updates here. It instead replaces label with label,host,endlabel. This > should keep backwards compatibility with notifications that just want a > label. > > Johann, does this changeset look good to you?
Reporter | ||
Comment 1•6 years ago
|
||
Attachment #8943515 -
Flags: review?(jhofmann)
Reporter | ||
Updated•6 years ago
|
status-firefox59:
--- → affected
Comment 2•6 years ago
|
||
Can we address the extra spaces (bug 1369482 comment 39) here? I think it would be a matter of putting all elements in <xul:description> on a single line in the markup
Reporter | ||
Comment 3•6 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #2) > Can we address the extra spaces (bug 1369482 comment 39) here? I think it > would be a matter of putting all elements in <xul:description> on a single > line in the markup I think Prathiksha is looking into that and will file a new bug with a patch when she has a solution, keeping the issues separate sounds more appropriate (and in this case more efficient) to me (though I'd also review a patch in this bug if it has to be).
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8943515 [details] [diff] [review] patch Review of attachment 8943515 [details] [diff] [review]: ----------------------------------------------------------------- r=me but you will also have to update https://searchfox.org/mozilla-central/source/browser/base/content/test/popupNotifications/head.js#207-213 to get all tests passing (and please do a try run afterwards). Thanks again for putting up a patch so quickly!
Attachment #8943515 -
Flags: review?(jhofmann) → review+
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #8943515 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #8943787 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Reporter | ||
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8943788 [details] Bug 1431320 - Add support for label back to popupnotification https://reviewboard.mozilla.org/r/214170/#review219976 Thank you!
Attachment #8943788 -
Flags: review?(jhofmann) → review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/332f7a698353 Add support for label back to popupnotification r=johannh
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/332f7a698353
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•