1431477 - [Mac] Firefox Developer Edition 59.0b1 has invalid bundle id

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Jamie Phelps]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/604.4.7 (KHTML, like Gecko) Version/11.0.2 Safari/604.4.7

Steps to reproduce:

* Install latest Firefox Developer Edition, 59.0b1
* Check bundle id: defaults read /Applications/FirefoxDeveloperEdition.app/Contents/Info | grep CFBundleIdentifier


Actual results:

An invalid bundle identifier is present. See https://help.apple.com/xcode/mac/current/#/dev9b66ae7df for requirements for valid bundle id.

This has broken 1Password's ability to recognize Firefox Developer Edition as an allowed browser because the new value does not match 1Password's internal whitelist.


Expected results:

A valid bundle identifier is present.

1Password recognizes the following bundle identifiers for various Firefox release channels:

* org.mozilla.firefox
* org.mozilla.aurora
* org.mozilla.nightly
* org.mozilla.firefoxdeveloperedition

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

See https://twitter.com/ivan3bx/status/954080710859657217 and attachment. Verifying. 

What would be the right component for this?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

I will fix that next week. sorry about that.

Comment 3

[Joël]

Just fyi the problem is still there in 59.0b2

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

Review commit: https://reviewboard.mozilla.org/r/214568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214568/

Comment 5

[onlydole]

Is there any more updates on this bug - been seeing this for a few days as well and am happy to test as needed!

Comment 6

[matt]

This is still happening in 59.0b3.

Comment 7

[tinhspace]

Just updated to newest version 59.0b3. Still happening.

Comment 8

[Martijn]

Can also confirm not fixed in 59.0b3.

Comment 9

[gregoire.piat]

Same issue on 59.0b3

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

https://reviewboard.mozilla.org/r/214568/#review220768

::: browser/branding/aurora/configure.sh:8
(Diff revision 1)
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  MOZ_APP_DISPLAYNAME="Firefox Developer Edition"
>  MOZ_APP_REMOTINGNAME=firefox-dev
>  MOZ_DEV_EDITION=1
> +MOZ_MACBUNDLE_ID=firefoxdeveloperedition

If spaces are invalid in MOZ_MACBUNDLE_ID, why not remove them here instead: https://dxr.mozilla.org/mozilla-central/rev/c4ebc8c28a33b785dfbfa533810517cc707d1ad0/old-configure.in#4384

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214568/diff/1-2/

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

https://reviewboard.mozilla.org/r/214568/#review220776

::: old-configure.in:4384
(Diff revision 2)
>  
>  dnl Mac bundle identifier (based on MOZ_APP_DISPLAYNAME)
>  # If the MOZ_MACBUNDLE_ID is defined in the configure.sh, use it
>  # Otherwise, use MOZ_APP_DISPLAYNAME
>  if test -z "$MOZ_MACBUNDLE_ID"; then
> -   MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr '[A-Z]' '[a-z]'`
> +   MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr '[A-Z]' '[a-z]' | tr -d '[:blank:]'`

Here's the funny thing about autoconf: this file is more m4 than shell. And autoconf uses [ and ] as opening and closing quotes. And funnily enough, those [] in the tr command are, actually, not in the generated old-configure. Which is fine, they were useless in the first place. But the ones for [:blank:] are more important.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214568/diff/2-3/

Comment 14

[Mike Hommey [:glandium]]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

https://reviewboard.mozilla.org/r/214568/#review220780

::: old-configure.in:4384
(Diff revision 3)
>  
>  dnl Mac bundle identifier (based on MOZ_APP_DISPLAYNAME)
>  # If the MOZ_MACBUNDLE_ID is defined in the configure.sh, use it
>  # Otherwise, use MOZ_APP_DISPLAYNAME
>  if test -z "$MOZ_MACBUNDLE_ID"; then
> -   MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr '[A-Z]' '[a-z]'`
> +   MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr '[A-Z]' '[a-z]' | tr -d '[[:blank:]]'`

You can remove the useless [] on the first tr while you're here.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cbb45faec894981794b33567c57140f591cb2f6
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces r=glandium

https://hg.mozilla.org/integration/mozilla-inbound/rev/40c125df036bde1df48c90c7231718836df102fe
Bug 1431477 - Ride along: Remove the useless [] (removed by the m4 step anyway) r=glandium

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1404796
[User impact if declined]: Issues with some addons (devedition only)
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Needs to be uplifted to beta to be tested
[Needs manual test from QE? If yes, steps to reproduce]: defaults read /Applications/FirefoxDeveloperEdition.app/Contents/Info | grep CFBundleIdentifier should return org.mozilla.firefoxdeveloperedition
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not much
[Why is the change risky/not risky?]: we are back in the state of 58beta
[String changes made/needed]: none

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking to make sure this lands for 59 beta.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8944359 [details]
Bug 1431477 - Fix the bundle ID for devedition by removing whitespaces

This should be in the 59.0b4 build tomorrow.

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6cbb45faec89
https://hg.mozilla.org/mozilla-central/rev/40c125df036b

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5798b4c1d8cd
https://hg.mozilla.org/releases/mozilla-beta/rev/4aedb56b41c7

Comment 21

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced using Firefox Developer Edition 59.0b1 under Mac OS X 10.13.
Verified as fixed using Firefox Developer Edition 59.0b6. Also checked that latest beta and Nightly builds have the correct bundle id's.

Comment 22

[Giovanny Gongora [:gioyik]]

This is broken again in Firefox Developer Edition on version 62.0b8 using 1Password 7.0.7.

I am getting similar errors than last time:

No such native application http://2bua8c4s2c.com .agilebits.1password NativeMessaging.jsm:99 NativeApp</this.startupPromise< resource://gre/modules/NativeMessaging.jsm:99:9 

1Password detected a high number of disconnections from the browser extension to the main application between Mon Jul 16 2018 10:49:18 GMT-0500 (-05) and Mon Jul 16 2018 10:51:18 GMT-0500 (-05)

Comment 23

[Martijn]

Can confirm 1password 6 still working fine on 62.0b8. Maybe this in a different issue.

Comment 24

[Rudy Richter]

I see no such issue with 7.0.7 and FFDE 62.0b8. 

If you have both 6 and 7 installed at the same time they're going to compete for writing out their JSON files. Have only one copy unzipped at a time. Also make sure that both 1Password and Firefox are in /Applications.

Failing that I'd want to see a DR, Contact 1Password support and be prepared to supply a Diagnostics Report https://support.1password.com/diagnostics/

Comment 25

[Giovanny Gongora [:gioyik]]

This happened just after I installed the Firefox addon. I closed and opened Firefox again and seems to work fine/as expected. Seems a behavior that happened a few moments after installed.

Everything seems fine now