1431575 - regression: white bars on tabs when loading whatsapp

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: 2018-01-19_02-49-44.mp4

install the theme, leave the tab open
switch to the whatsapp tab, login, press F5

mozregression --good 2017-12-01 --bad 2018-01-10 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/" startup.homepage_welcome_url.additional:"https://web.whatsapp.com"
> 12:51.35 INFO: Last good revision: c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4
> 12:51.35 INFO: First bad revision: 8ccb0e9d9bbeeed7d7e4474849debd7d21b65971
> 12:51.35 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4&tochange=8ccb0e9d9bbeeed7d7e4474849debd7d21b65971

> 8ccb0e9d9bbe	Ethan Lin — Bug 1426116 - Update the reftest annotations after we fixed the webrender box shadow problem (WR PR 2261). r=kats
> ca6f08cff784	Kartikaya Gupta — Bug 1426116 - Update reftest results from WR PR 2262. r=jrmuizel
> a7f7b7350673	Kartikaya Gupta — Bug 1426116 - Update reftest results for changes from WR PR 2200. r=jrmuizel
> 39f6c70f793e	Kartikaya Gupta — Bug 1426116 - Regenerate FFI header and remove RGB8 references to go with changes in WR PR 2260. r=jrmuizel
> e37afa9046ed	Kartikaya Gupta — Bug 1426116 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> 7855af69185d	Kartikaya Gupta — Bug 1426116 - Update for changes in WR PR 2251. r=jrmuizel
> da9b75fc0866	Kartikaya Gupta — Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e. r=jrmuizel

There are two other regressions blocking bug 1426116.

Comment 1

[Darkspirit]

Attachment: 2018-01-19_03-09-20.mp4

I can also reproduce this with the dark theme, but then only the forward button is light-grey for a moment.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Narrowed the regression range down to this:

*   4e6310e8 Auto merge of #2257 - zakorgy:patch-1, r=nical
|\
| * 9066f565 Remove legacy shader part from build_shader_strings
*   92959212 Auto merge of #2255 - glennw:fix-3dxf, r=kvark
|\
| * c66209e1 Make incompatible coordinate system detection more conservative.
* 3a905e7e Auto merge of #2251 - Gankro:deserialize_in_place, r=glennw
* 52c3ecef Stop using the serde_derive feature for no good reason
* f879af5f Update serde to 1.0.27, removing some of the patch hacks

So it's probably one of #2257 or #2255.

Comment 3

[Darkspirit]

I think this got fixed.

try builds from bug 1436058:
> WR @ 08e49649f1fc9cacff4e10ebc390babcea752236
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9ad3b81dd77ed55a7860af182e6a5a849769dcf
mozregression --repo try --launch a9ad3b81dd77ed55a7860af182e6a5a849769dcf --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/|https://web.whatsapp.com|about:newtab|about:newtab|about:newtab"
bad

> WR @ a4202af2130e999ead44e10d8eb4f323c0ddb582
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef6d3bc2aa54aa9d8f1be8dc84d5ec1934ab3eb
mozregression --repo try --launch eef6d3bc2aa54aa9d8f1be8dc84d5ec1934ab3eb --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/|https://web.whatsapp.com|about:newtab|about:newtab|about:newtab"
bad

> WR @ d96d02bd9b8141c2fa4a692ee0b35220be0a8873
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd2a2ceffa4abbc8852aa19c7a3ba566b828fc72
mozregression --repo try --launch bd2a2ceffa4abbc8852aa19c7a3ba566b828fc72 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/|https://web.whatsapp.com|about:newtab|about:newtab|about:newtab"
bad

> WR @ 30f2cd5e648bbcadbe8200d479de3f7d76089d0b
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be1a14608bff4f0ae6b45af286120e83d7a41df
mozregression --repo try --launch 3be1a14608bff4f0ae6b45af286120e83d7a41df --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/|https://web.whatsapp.com|about:newtab|about:newtab|about:newtab"
bad

> WR @ e7c95ae9fb6b7f8d973ae5106a1ba8be6adea007 with log fixes
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e55bcc9125cc9cc60f5dd9d4de4d633544cd4bb6
mozregression --repo try --launch e55bcc9125cc9cc60f5dd9d4de4d633544cd4bb6 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/|https://web.whatsapp.com|about:newtab|about:newtab|about:newtab"
good 

> WR @ 65c68cc1d1d8958c103fa3a528b05d81e27783d3 with the updated patch from bug 1432708
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=16522f15dc603cf33295af84acfb2f15004e8c62
mozregression --repo try --launch 16522f15dc603cf33295af84acfb2f15004e8c62 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://addons.mozilla.org/en-US/firefox/addon/quantum-lights-dynamic/|https://web.whatsapp.com|about:newtab|about:newtab|about:newtab"
good

https://github.com/servo/webrender/compare/30f2cd5e648bbcadbe8200d479de3f7d76089d0b...e7c95ae9fb6b7f8d973ae5106a1ba8be6adea007

Comment 4

[Glenn Watson [:gw]]

There's been a couple of fixes recently that I can imagine may fix this.

Comment 5

[Glenn Watson [:gw]]

I'm still unable to reproduce this, should it be marked FIXED?

Comment 6

[Darkspirit]

That's the fix range I could identify.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

This being fixed with a PR - is there a Gecko side reftest that we can add that catches this problem?