1431725 - Rename "tabHide" permission to "tabs.hide" for consistency

Status: RESOLVED WONTFIX

(WebExtensions :: General, enhancement, P2)

Description

[Tim Nguyen :ntim]

The permission for downloads.open() is "downloads.open", hence "tabHide" should also be consistent and become "tabs.hide".

Comment 1

[Shane Caraveo (:mixedpuppy)]

@wbamberg FYI, I'm going to make this change and get it uplifted.  We should reflect that in docs.

Comment 2

[Shane Caraveo (:mixedpuppy)]

I'm actually on the fence about this.  downloads.open is the only permission we have that isn't camelCased.  An older example is webRequest and webRequestBlocking.  We also have tabs and activeTab (rather than tabs.active), clipboardRead and clipboardWrite, rather than clipboard.read/write.  If anything, we probably should have used tabsHide.  I'll ping the team on irc for input.

Comment 3

[Tim Nguyen :ntim]

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> I'm actually on the fence about this.  downloads.open is the only permission
> we have that isn't camelCased.  An older example is webRequest and
> webRequestBlocking.  We also have tabs and activeTab (rather than
> tabs.active), clipboardRead and clipboardWrite, rather than
> clipboard.read/write.  If anything, we probably should have used tabsHide. 
> I'll ping the team on irc for input.

That's because there are no methods called webRequest.blocking/clipboard.read/clipboard.write/tabs.active.

There is a method called downloads.open, and one called tabs.hide, so I think "tabs.hide" makes sense here.

Comment 4

[Shane Caraveo (:mixedpuppy)]

(In reply to Tim Nguyen :ntim from comment #3)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> > I'm actually on the fence about this.  downloads.open is the only permission

> There is a method called downloads.open, and one called tabs.hide, so I
> think "tabs.hide" makes sense here.

tabHide covers both tabs.hide and tabs.show, so it's not a 1:1 match to the api.  Maybe it should be tabVisibility.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Thought on this more & talked with mconca.  We're just going to stick with tabHide on this.  If tabstrip hiding becomes a thing, it may also be covered under this permission.