1431797 - Sandbox MinGW Compilation errors: header capialization

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr]]

Probably will leave this one open while I try to hunt all these down.

Comment 1

[Tom Ritter [:tjr]]

I'll also avoid doing the .patch addition and upstream request until I think I've found them all.

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1431797 Correct the capitalization of headers inside the chromium code so MinGW can compile

Review commit: https://reviewboard.mozilla.org/r/214352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214352/

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1431797 Fix capitalization in mozilla files so the sandbox can compile on MinGW

This patch also adds the capitalization patch file to the chromium patches

Review commit: https://reviewboard.mozilla.org/r/215428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215428/

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8944031 [details]
Bug 1431797 Correct the capitalization of headers inside the chromium code so MinGW can compile

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214352/diff/1-2/

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 8944031 [details]
Bug 1431797 Correct the capitalization of headers inside the chromium code so MinGW can compile

https://reviewboard.mozilla.org/r/214352/#review221086

Plus patch please.

Comment 6

[Bob Owen (:bobowen)]

Comment on attachment 8945191 [details]
Bug 1431797 Fix capitalization in mozilla files so the sandbox can compile on MinGW

https://reviewboard.mozilla.org/r/215428/#review221090

Ah there it is. :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b4b24642ae3
Correct the capitalization of headers inside the chromium code so MinGW can compile r=bobowen
https://hg.mozilla.org/integration/autoland/rev/6067a5ed02a1
Fix capitalization in mozilla files so the sandbox can compile on MinGW r=bobowen

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8b4b24642ae3
https://hg.mozilla.org/mozilla-central/rev/6067a5ed02a1

Comment 9

[Ionuț Goldan [:igoldan]]

This improved our build times on Windows:

== Change summary for alert #11273 (as of Thu, 25 Jan 2018 00:32:03 GMT) ==

Improvements:

  6%  build times windows2012-64 opt rusttests taskcluster-c4.4xlarge     2,132.85 -> 1,995.24
  6%  build times windows2012-32 opt rusttests taskcluster-c4.4xlarge     2,083.20 -> 1,964.84
  5%  build times windows2012-32 opt taskcluster-c4.4xlarge               2,368.75 -> 2,250.14
  5%  build times windows2012-64 opt taskcluster-c4.4xlarge               2,437.23 -> 2,323.95

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11273