Closed
Bug 1431797
Opened 7 years ago
Closed 7 years ago
Sandbox MinGW Compilation errors: header capialization
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor][mingw-upstream-pending])
Attachments
(2 files)
Probably will leave this one open while I try to hunt all these down.
Assignee | ||
Comment 1•7 years ago
|
||
I'll also avoid doing the .patch addition and upstream request until I think I've found them all.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8944031 [details] Bug 1431797 Correct the capitalization of headers inside the chromium code so MinGW can compile https://reviewboard.mozilla.org/r/214352/#review221086 Plus patch please.
Attachment #8944031 -
Flags: review?(bobowencode) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8945191 [details] Bug 1431797 Fix capitalization in mozilla files so the sandbox can compile on MinGW https://reviewboard.mozilla.org/r/215428/#review221090 Ah there it is. :-)
Attachment #8945191 -
Flags: review?(bobowencode) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8b4b24642ae3 Correct the capitalization of headers inside the chromium code so MinGW can compile r=bobowen https://hg.mozilla.org/integration/autoland/rev/6067a5ed02a1 Fix capitalization in mozilla files so the sandbox can compile on MinGW r=bobowen
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8b4b24642ae3 https://hg.mozilla.org/mozilla-central/rev/6067a5ed02a1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment 9•7 years ago
|
||
This improved our build times on Windows: == Change summary for alert #11273 (as of Thu, 25 Jan 2018 00:32:03 GMT) == Improvements: 6% build times windows2012-64 opt rusttests taskcluster-c4.4xlarge 2,132.85 -> 1,995.24 6% build times windows2012-32 opt rusttests taskcluster-c4.4xlarge 2,083.20 -> 1,964.84 5% build times windows2012-32 opt taskcluster-c4.4xlarge 2,368.75 -> 2,250.14 5% build times windows2012-64 opt taskcluster-c4.4xlarge 2,437.23 -> 2,323.95 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11273
You need to log in
before you can comment on or make changes to this bug.
Description
•