Closed
Bug 1432295
Opened 7 years ago
Closed 7 years ago
Sandbox MinGW Compilation errors: error: invalid conversion from ‘FARPROC {aka int (__attribute__((__stdcall__)) *)()}’ to ‘const void*’
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor][mingw-upstream-pending])
Attachments
(1 file)
0:03.50 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/resolver.cc:56:31: error: invalid conversion from ‘FARPROC {aka int (__attribute__((__stdcall__)) *)()}’ to ‘const void*’ [-fpermissive]
0:03.50 *address = pe.GetProcAddress(interceptor_name);
0:03.50 ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8944545 [details]
Bug 1432295 Cast GetProcAddress to (void*)
https://reviewboard.mozilla.org/r/214712/#review220464
::: security/sandbox/chromium/sandbox/win/src/resolver.cc:56
(Diff revision 1)
>
> base::win::PEImage pe(interceptor_module);
> if (!pe.VerifyMagic())
> return STATUS_INVALID_IMAGE_FORMAT;
>
> - *address = pe.GetProcAddress(interceptor_name);
> + *address = (void*)pe.GetProcAddress(interceptor_name);
static_cast<void*> for these please.
Attachment #8944545 -
Flags: review?(bobowencode) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8dd3b7fc5480
Cast GetProcAddress to (void*) r=bobowen
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•