1432295 - Sandbox MinGW Compilation errors: error: invalid conversion from ‘FARPROC {aka int (__attribute__((__stdcall__)) *)()}’ to ‘const void*’

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr]]

0:03.50 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/resolver.cc:56:31: error: invalid conversion from ‘FARPROC {aka int (__attribute__((__stdcall__)) *)()}’ to ‘const void*’ [-fpermissive]
 0:03.50    *address = pe.GetProcAddress(interceptor_name);
 0:03.50               ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1432295 Cast GetProcAddress to (void*)

error: invalid conversion from 'FARPROC {aka int (__attribute__((__stdcall__)) *)()}' to 'void*' [-fpermissive]

According to http://stackoverflow.com/questions/13958081/, msvc does the fixup
for itself automatically, while for mingw we need to do it manually.

Review commit: https://reviewboard.mozilla.org/r/214712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214712/

Comment 2

[Bob Owen (:bobowen) PTO until 29th Oct]

Comment on attachment 8944545 [details]
Bug 1432295 Cast GetProcAddress to (void*)

https://reviewboard.mozilla.org/r/214712/#review220464

::: security/sandbox/chromium/sandbox/win/src/resolver.cc:56
(Diff revision 1)
>  
>    base::win::PEImage pe(interceptor_module);
>    if (!pe.VerifyMagic())
>      return STATUS_INVALID_IMAGE_FORMAT;
>  
> -  *address = pe.GetProcAddress(interceptor_name);
> +  *address = (void*)pe.GetProcAddress(interceptor_name);

static_cast<void*> for these please.

Comment 3

[Tom Ritter [:tjr]]

Comment on attachment 8944545 [details]
Bug 1432295 Cast GetProcAddress to (void*)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214712/diff/1-2/

Comment 4

[Tom Ritter [:tjr]]

Patch Order: Bug 1432239 , Bug 1432295 (this bug), Bug 1432313

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dd3b7fc5480
Cast GetProcAddress to (void*) r=bobowen

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8dd3b7fc5480