Closed Bug 1432295 Opened 2 years ago Closed 2 years ago

Sandbox MinGW Compilation errors: error: invalid conversion from ‘FARPROC {aka int (__attribute__((__stdcall__)) *)()}’ to ‘const void*’

Categories

(Core :: Security: Process Sandboxing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

(Whiteboard: [tor][mingw-upstream-pending])

Attachments

(1 file)

0:03.50 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/resolver.cc:56:31: error: invalid conversion from ‘FARPROC {aka int (__attribute__((__stdcall__)) *)()}’ to ‘const void*’ [-fpermissive]
 0:03.50    *address = pe.GetProcAddress(interceptor_name);
 0:03.50               ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
Blocks: 1432313
Comment on attachment 8944545 [details]
Bug 1432295 Cast GetProcAddress to (void*)

https://reviewboard.mozilla.org/r/214712/#review220464

::: security/sandbox/chromium/sandbox/win/src/resolver.cc:56
(Diff revision 1)
>  
>    base::win::PEImage pe(interceptor_module);
>    if (!pe.VerifyMagic())
>      return STATUS_INVALID_IMAGE_FORMAT;
>  
> -  *address = pe.GetProcAddress(interceptor_name);
> +  *address = (void*)pe.GetProcAddress(interceptor_name);

static_cast<void*> for these please.
Attachment #8944545 - Flags: review?(bobowencode) → review+
Patch Order: Bug 1432239 , Bug 1432295 (this bug), Bug 1432313
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8dd3b7fc5480
Cast GetProcAddress to (void*) r=bobowen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8dd3b7fc5480
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1431797
You need to log in before you can comment on or make changes to this bug.