Closed
Bug 1431807
Opened 7 years ago
Closed 7 years ago
Sandbox MinGW Compilation errors: #error if it doesn't like your MSVC version
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor][mingw-upstream-pending])
Attachments
(1 file)
> 0:01.59 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc:18:2: error: #error VS 2015 Update 3 with Cumulative Servicing Release or higher is required
> 0:01.59 #error VS 2015 Update 3 with Cumulative Servicing Release or higher is required
> 0:01.59 ^~~~~
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8944046 [details]
Bug 1431807 Allow MinGW and silence warning about Windows SDK version
https://reviewboard.mozilla.org/r/214378/#review220068
Attachment #8944046 -
Flags: review?(bobowencode) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
Patch land order: 1431621, 1431801, 1431807 (this bug), 1431825
Blocks: 1431825
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/19ed6063a4b2
Allow MinGW and silence warning about Windows SDK version r=bobowen
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•