Closed Bug 1431807 Opened 2 years ago Closed 2 years ago

Sandbox MinGW Compilation errors: #error if it doesn't like your MSVC version

Categories

(Core :: Security: Process Sandboxing, defect)

Product:
Core
Component:
Security: Process Sandboxing
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

(Whiteboard: [tor][mingw-upstream-pending])

Attachments

(1 file)

Bug 1431807 Allow MinGW and silence warning about Windows SDK version
59 bytes, text/x-review-board-request
bobowen
: review+
Details 
> 0:01.59 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/windows_version.cc:18:2: error: #error VS 2015 Update 3 with Cumulative Servicing Release or higher is required
> 0:01.59  #error VS 2015 Update 3 with Cumulative Servicing Release or higher is required
> 0:01.59   ^~~~~
Comment on attachment 8944046 [details]
Bug 1431807 Allow MinGW and silence warning about Windows SDK version

https://reviewboard.mozilla.org/r/214378/#review220068
Attachment #8944046 - Flags: review?(bobowencode) → review+
Patch land order: 1431621, 1431801, 1431807 (this bug), 1431825
Blocks: 1431825
Keywords: checkin-needed
Depends on: 1431801
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/19ed6063a4b2
Allow MinGW and silence warning about Windows SDK version r=bobowen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/19ed6063a4b2
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1498694
You need to log in before you can comment on or make changes to this bug.