1431825 - Sandbox MinGW Compilation errors: _Copy_s not defined

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr]]

0:02.86 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/handle_closer.cc:150:14: error: ‘const class std::__cxx11::basic_string<wchar_t>’ has no member named ‘_Copy_s’
 0:02.87      i->first._Copy_s(output, i->first.size(), i->first.size());
 0:02.87               ^~~~~~~

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1431825 Map _Copy_s to copy for basic_string compatibility on MinGW

Review commit: https://reviewboard.mozilla.org/r/214386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214386/

Comment 2

[Bob Owen (:bobowen)]

Comment on attachment 8944061 [details]
Bug 1431825 Map _Copy_s to copy for basic_string compatibility on MinGW

https://reviewboard.mozilla.org/r/214386/#review220104

Comment 3

[Bob Owen (:bobowen)]

I realised after that we could do this (and maybe some of the others) by having another force included file like sdkdecls.h [1]

However, given that we are going to try and upstream these it's probably best to keep them in the files, so it's easy to spot if we get them through updates.
If some of these get refused upstream then we could revisit that.

[1] https://searchfox.org/mozilla-central/source/mozilla-config.h.in#59

Comment 4

[Tom Ritter [:tjr]]

Patch land order: 1431621, 1431801, 1431807, 1431825 (this bug)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db488f44ba6b
Map _Copy_s to copy for basic_string compatibility on MinGW r=bobowen

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/db488f44ba6b