1432052 - [Form Autofill][a11y] Bug 1412247 regressed accessibility and mouse behaviour for Autofill preferences

Status: RESOLVED DUPLICATE of bug 1488011

(Toolkit :: Form Autofill, defect, P3)

Description

[Ian Moody [:Kwan] (UTC+0)]

STR:
0) have autofill activated
1) Go to about:preferences#privacy
2) Try tabbing to the "Autofill addresses" or "Autofill credit cards" controls

ER:
Labels receive outline like other preference controls

AR:
Labels don't receive outline, keyboard user can no longer tell where focus is
(there is barely noticeable focus outline that looks like a ` at the level of -, just at the start of the text)


STR 2:
1) Hover the mouse over either of "Autofill addresses" or "Autofill credit cards" labels
2) Middle or right-click the hovered label

ER:
1) Checkbox outline gains colour
2) nothing

AR:
1) nothing
2) Control changes state

Tabbing outline is fixable with some CSS (checkbox:focus + label { outline: ... })
Hovering is sort of fixable with more CSS (#formAutofillGroup > hbox > :first-child:hover > checkbox etc,), but would then also do it when learn more is hovered, so would still be wrong. (I guess could also try doing it with JS mouseover listeners)
Clicking is fixable by checking the button type (chrome is different to the web, it gets click for all buttons, not just the primary)

But at this point this all seems to feel rather bodgy and fragile.

I think there's three courses of action with the current constraints:
1) Just backout bug 1412247 and live with the learn more link being on a newline.
2) Backout bug 1412247 and get rid of the <description> and don't wrap at all, which is what all the other prefs with learn more links seem to do.
3) Backout bug 1412247 and move the learn more link outside the <description> so the label can wrap inside itself.  Side effect is even with a spacer between learn more and button this seems to ends up with learn more over by the button if the label wraps.

Alternatively stop having two learn more links (since they go to the same URL), and just have one above/below, with a longer string like tracking protection's learn more link.  Could change if credit card is available
"Learn more about address autofill"
"Learn more about address and credit card autofill"

Comment 2

[Winson Wen]

I think this has been fixed in the latest Nightly?

Comment 3

[Matthew N. [:MattN]]

Yes, by bug 1488011 I think.