1432213 - Windows mingw32 builds are failing on Gecko 58 since the uplift to Beta (Automation Error: Can't checkout https://hg.mozilla.org/build/tools! | Caught exception: could not find the robustcheckout Mercurial extension)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Tom Ritter [:tjr]]

Alright, need to actually fix this now.

+++ This bug was initially created as a clone of Bug #1414016 +++

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=141726323&repo=mozilla-beta

https://queue.taskcluster.net/v1/task/Y874Dzv_SIeMFRQrpvN0dw/runs/0/artifacts/public/logs/live_backing.log

Sorry, I'd been seeing these in my Try simulations as well but had chalked it up to something odd happening with the config hackery needed to support those pushes. Looks like it's real after all.

Comment 1

[Tom Ritter [:tjr]]

Repro-ed broken try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b69c2718531b23f0bf84984af6e0cfbdc034719&selectedJob=158271410

Fixed try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=191e8e50f466b6c3d8c9b0dda429c00fcafd00df

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1432213 Fix the MinGW build on the beta branch and re-enable it

When we branched to beta, the MinGW build started failing with a strange error
like "could not find the robustcheckout Mercurial extension".

The root culprit of this was that we were using the incorrect mozconfig. MinGW
does all sorts of stuff in the mozconfig, but the beta branch overrides the
mozconfig using platform_overrides in
testing/mozharness/configs/builds/branch_specifics.py

We avoid this override by changing the MinGW platform so it doesn't match
and the mozconfig doesn't get overridden.

Review commit: https://reviewboard.mozilla.org/r/215432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215432/

Comment 3

[Tom Ritter [:tjr]]

Comment on attachment 8945201 [details]
Bug 1432213 Fix the MinGW build on the beta branch and re-enable it

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215432/diff/1-2/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8945201 [details]
Bug 1432213 Fix the MinGW build on the beta branch and re-enable it

https://reviewboard.mozilla.org/r/215432/#review221262

I think I might be willing to believe that this does what you want, but I am super-confused about the commit message vs. the code.  Am I missing something huge here?

::: commit-message-3629e:11
(Diff revision 2)
> +We avoid this override by changing the MinGW platform so it doesn't match
> +and the mozconfig doesn't get overridden.

The current situation is that we are running mingw builds on Beta, and those builds are broken, yes?  And this function is returning `False` for tasks we *don't* want to run, yes?  So the current code is actually *not* running the mingw task?  I am confused, then. :)

I am also confused by this bit of the commit message.  We're changing the platform so it doesn't match...but the patch looks like it changes the platform so it *does* match what `target_tasks.py` was looking for, so we would be disabling the task.  But then we remove the `wind32-mingw32` filter from `target_tasks.py` so it looks like we're re-enabling mingw builds?

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8945201 [details]
Bug 1432213 Fix the MinGW build on the beta branch and re-enable it

https://reviewboard.mozilla.org/r/215432/#review221276

OK, RyanVM explained this to me in #build.  I should have actually looked at `branch_specifics.py` to see what was going on; for some reason I assumed that file would be in the patch--and then didn't bother to verify that assumption!

Comment 6

[Tom Ritter [:tjr]]

Comment on attachment 8945201 [details]
Bug 1432213 Fix the MinGW build on the beta branch and re-enable it

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215432/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47c9d061fa94
Fix the MinGW build on the beta branch and re-enable it r=froydnj

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7047d5147ac6

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/47c9d061fa94