Closed
Bug 1432222
Opened 6 years ago
Closed 6 years ago
Running `mach cargo check` doesn't do anything
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
If you run `mach cargo check`, crates ends up as [] (an empty array) at [1], rather than None. So it doesn't pick up the default of 'gkrust', and it doesn't do anything useful. [1] https://searchfox.org/mozilla-central/rev/b7e3ec2468d42fa59d86c03ec7afeb209813f1d4/python/mozbuild/mozbuild/mach_commands.py#289
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bugmail
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8944464 [details] Bug 1432222 - Actually default cargo check to gkrust when invoked without any crate arguments. https://reviewboard.mozilla.org/r/214654/#review220284
Attachment #8944464 -
Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/679d44b3cfb0 Actually default cargo check to gkrust when invoked without any crate arguments. r=froydnj
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/679d44b3cfb0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•