1432222 - Running `mach cargo check` doesn't do anything

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

If you run `mach cargo check`, crates ends up as [] (an empty array) at [1], rather than None. So it doesn't pick up the default of 'gkrust', and it doesn't do anything useful.

[1] https://searchfox.org/mozilla-central/rev/b7e3ec2468d42fa59d86c03ec7afeb209813f1d4/python/mozbuild/mozbuild/mach_commands.py#289

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1432222 - Actually default cargo check to gkrust when invoked without any crate arguments.

Review commit: https://reviewboard.mozilla.org/r/214654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214654/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8944464 [details]
Bug 1432222 - Actually default cargo check to gkrust when invoked without any crate arguments.

https://reviewboard.mozilla.org/r/214654/#review220284

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/679d44b3cfb0
Actually default cargo check to gkrust when invoked without any crate arguments. r=froydnj

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/679d44b3cfb0