1378440 - add `mach cargo check` command

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

No reason Gecko developers shouldn't have this.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - make Cargo invocation macro more generic

All the machinery we set up for `cargo build` is equally useful for
other commands, such as `cargo check`.  Let's refactor things so that
it's easy to reuse said machinery for `cargo check`.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - add `mach cargo check`

Cargo recently introduced the `cargo check` command for shortening the
edit-compile cycle when working on large programs.  Since we don't
really support invoking `cargo` directly, let's wire up this command to
`mach`.  Gecko developers can then `mach cargo check` to ensure their
changes typecheck.

I'm not completely happy with the rules.mk changes, but they were the easiest
way I could think of doing things, since I didn't want to store information on
what *kind* of crate we had at the mach level.  I just wanted to say "check",
and let the Makefile sort out what needs doing.  Let me know what you think.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8883633 [details] [diff] [review]
part 2 - add `mach cargo check`

Review of attachment 8883633 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks for doing this!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4168fad05a11
part 1 - make Cargo invocation macro more generic; r=rillian
https://hg.mozilla.org/integration/mozilla-inbound/rev/90323301d1b1
part 2 - add `mach cargo check`; r=rillian

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4168fad05a11
https://hg.mozilla.org/mozilla-central/rev/90323301d1b1