1432223 - Add a --all option to `mach cargo check` to check all the crates

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

This is useful in some cases. The case I care about is running `cargo check` on all the crates with RUSTFLAGS='-Zsave-analysis' to generate the rust analysis for all the crates for searchfox.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1432223 - Add an --all-crates option to mach cargo check, to check all the crates.

Review commit: https://reviewboard.mozilla.org/r/214658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214658/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

... although after I wrote this patch I realized there's a different/better way to get what I want for searchfox so I don't really need this. Somebody else might find it useful though.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8944467 [details]
Bug 1432223 - Add an --all-crates option to mach cargo check, to check all the crates.

https://reviewboard.mozilla.org/r/214658/#review221334

Sure, why not?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89f827270939
Add an --all-crates option to mach cargo check, to check all the crates. r=froydnj

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/89f827270939