Implement restore all for blocked sites

NEW
Unassigned

Status

()

enhancement
P3
normal
2 years ago
17 days ago

People

(Reporter: Mardak, Unassigned)

Tracking

(Blocks 2 bugs)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix)

Details

(Whiteboard: [strings needed][parity])

From https://github.com/mozilla/activity-stream/issues/2026

Split from #1982. If you block a site in about:newtab you have the option to 'restore all' which unblocks all your blocked sites

uiwanted: How to handle "restore all" (separate from "undo")
See Also: → 1432307
With the move to about:preferences in bug 1417155, a "restore all blocked" button would be relatively straightforward to implement that clears the pref, etc.

uiwanted: what's the strings for the button and any related text?
Blocks: 1432589
Iteration: --- → 60.4 - Mar 12
Depends on: 1417155
Priority: P3 → P2
Severity: normal → enhancement
Whiteboard: [strings needed][parity] → [strings needed][parity] [AS60MVP]
Blocks: 1437659
Moved to early 61 for strings
Iteration: 60.4 - Mar 12 → 61.2 - Apr 9
Priority: P2 → P3
Whiteboard: [strings needed][parity] [AS60MVP] → [strings needed][parity] [AS61MVP]
Priority: P3 → P2
Flags: needinfo?(abenson)
Iteration: 61.2 - Apr 9 → 61.4 - May 7
Iteration: 61.4 - May 7 → 61.2 - Apr 9
Iteration: 61.2 - Apr 9 → 61.3 - Apr 23
Iteration: 61.3 - Apr 23 → ---
Iteration: --- → 62.1 - May 21
Priority: P2 → P3
Iteration: 62.1 - May 21 → 62.2 - Jun 4
Iteration: 62.2 - Jun 4 → 63.1 - July 9
Iteration: 63.1 - July 9 → 63.2 - July 23
uifeedback: Aaron to provide designs on where this should look and behave in about:preferences.

Some quick notes from the meeting, this could be an "Advanced" type section similar to the current bolded "Firefox Home Content" header. In particular, blocked sites also include top sites and highlights and pocket, so it doesn't make sense to put a "restore all" just underneath "Top Sites" section. Also sounds like the "restore all" button (?) and accompanying text should always be visible although the button should be disabled if there's nothing to restore.
Iteration: 63.2 - July 23 → 63.3 - Aug 6
(In reply to Amy Lee [:amylee] UX from comment #4)
> https://mozilla.invisionapp.com/share/64MXHV9DEP2#/screens
Bryan, I thought we explicitly said we didn't want to do an unblock/unhide temporary toast message. We wontfixed bug 1432307 and kept this one for just the about:preferences restore button.
Flags: needinfo?(bbell)
Hey Ed, I know we said we didn't want to do the toast before but it became pretty clear as we worked through the flow that we needed to communicate better what was happening after you dismiss a site. The toast modal gives us the opportunity to quickly undo, but also points people where to go to undo all of these.
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Iteration: 63.3 - Aug 6 → 63.4 - Aug 20
See Also: → 1477709
Iteration: 63.4 - Aug 20 → 63.5 - Sep 3
Iteration: 63.5 - Sep 3 → 64.2 (Sep 28)
Iteration: 64.2 (Sep 28) → ---
Keywords: uiwanted
Whiteboard: [strings needed][parity] [AS61MVP] → [strings needed][parity]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.