1432576 - Remove B2G shared global isms from Promise.jsm

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, enhancement)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Promise.jsm defines this.Cc etc. as an adaptation to the particular way B2G was doing shared globals, but that isn't needed any more.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1432576 - Remove B2G shared global isms from Promise.jsm.

B2G used to do shared globals in a weird way which required this, but
that is no longer used.

Review commit: https://reviewboard.mozilla.org/r/215018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215018/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8944859 [details]
Bug 1432576 - Remove B2G shared global isms from Promise.jsm.

https://reviewboard.mozilla.org/r/215018/#review220644

rs=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1484bf37d1e
Remove B2G shared global isms from Promise.jsm. r=Gijs

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d1484bf37d1e

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8944859 [details]
Bug 1432576 - Remove B2G shared global isms from Promise.jsm.

https://reviewboard.mozilla.org/r/215018/#review220824

::: toolkit/modules/Promise.jsm:9
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  "use strict";
>  
> -this.EXPORTED_SYMBOLS = [
> +var EXPORTED_SYMBOLS = [

Would it make sense to do this change everywhere?

Comment 6

[Andrew McCreight (out of office until 8/21) [:mccr8]]

(In reply to Florian Quèze [:florian] from comment #5)
> Would it make sense to do this change everywhere?

I think so. At least, I find the "this." way of doing it to be ugly, and it isn't needed any more.

Comment 7

[Florian Quèze [:florian]]

(In reply to Andrew McCreight [:mccr8] from comment #6)
> (In reply to Florian Quèze [:florian] from comment #5)
> > Would it make sense to do this change everywhere?
> 
> I think so. At least, I find the "this." way of doing it to be ugly, and it
> isn't needed any more.

Ok, I'll treat this comment as an offer to review my patch if I do this mass change in the next few days :-).