1432578 - Remove B2G shared global isms from server/main.js

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Andrew McCreight [:mccr8]]

server/main.js defines this.Cc etc. as an adaptation to the particular way B2G was doing shared globals, but that isn't needed any more.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1432578 - Remove B2G shared global isms from server/main.js.

B2G used to do shared globals in a weird way which required this, but
that is no longer used.

Review commit: https://reviewboard.mozilla.org/r/215022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215022/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8944860 [details]
Bug 1432578 - Remove B2G shared global isms from server/main.js.

https://reviewboard.mozilla.org/r/215022/#review220648

Thanks for the cleanup! :) Looks good to me.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8944860 [details]
Bug 1432578 - Remove B2G shared global isms from server/main.js.

https://reviewboard.mozilla.org/r/215022/#review220650

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bd1a3505e22
Remove B2G shared global isms from server/main.js. r=jryans

Comment 5

[Andreea Pavel [:apavel]]

Backed out for ESlint failure at /builds/worker/checkouts/gecko/testing/xpcshell/dbg-actors.js

Push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5bd1a3505e22e1735c0bb832e12ccfec4c2037db

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=158063380&repo=autoland&lineNumber=229

Backout: https://hg.mozilla.org/integration/autoland/rev/b3aee82221e8f796a3a17827b7332ce608fb54cf

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8944860 [details]
Bug 1432578 - Remove B2G shared global isms from server/main.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215022/diff/1-2/

Comment 7

[Andrew McCreight [:mccr8]]

I noticed an eslint failure in another file when I did a try push, which I fixed, but I didn't realize it might cause a failure in another file. I ran a full eslint run locally, so hopefully there's nothing else lurking.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/014c005aae3d
Remove B2G shared global isms from server/main.js. r=jryans

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/014c005aae3d