1432595 - Add section in prefs to turn off parts of Highlights

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

From https://github.com/mozilla/activity-stream/issues/3155

At minimum the whole section can be turned off but the full feature is to be able to individually turn off bookmarks and visited sites.

https://mozilla.invisionapp.com/share/4CCZSU2BU#/screens/248174509_New_Tab_Prefs

image

Pref pane behavior:

    If the user unchecks both Bookmarks and Visited Sites, the Highlights section is also unchecked.
    If Highlights section is unchecked, the sub option box is disabled at 50% opacity not allowing clicks but maintains whatever the user has checked for Bookmarks and Visited Sites.
    If all sub options are unchecked and the user is turning on Highlights section, all options are now checked.

Highlight section behavior (from #3378 (comment)):

    If the user is excluding Bookmarks, all items should appear as Visited but context menu allows removing a bookmarked page. They keep the Visited type even when bookmarked and without shifting around cards, but the context menu will update to allow Remove Bookmark.
    If the user is excluding Visited Sites, only bookmarks should appear, and these show Bookmarked. If the user then Remove Bookmark from context menu, that card is dismissed immediately.

Comment 1

[Ed Lee :Mardak]

The strings for bookmarks and visited sites should already have been landed.

Comment 2

[Ed Lee :Mardak]

Will be more needed when we add other data types (more than the current history + bookmarks, and the incoming pocket)

Comment 4

[Ed Lee :Mardak]

Looks like we're missing strings for including pocket in highlights.

Comment 5

[Aaron Benson]

Looks like an old InVision mock is linked above. Here's the updated version. https://mozilla.invisionapp.com/share/MFGXGZIG5JD#/280785532_Explainer

The string we'd need is "Pocket Saves".

Comment 6

[Ed Lee :Mardak]

With downloads in highlights maybe landing soon, I suppose we should have a checkbox for that too.. even though we only show a single download? "[✓] Downloads" ?

Comment 7

[Aaron Benson]

Should say "[✓] Most Recent Download"

Comment 8

[Ed Lee :Mardak]

(In reply to Aaron Benson from comment #5)
> https://mozilla.invisionapp.com/share/MFGXGZIG5JD#/280785532_Explainer
The mock only has 3 options:
[✓] Visited Pages
[✓] Most Recent Download
[✓] Pocket Saves

Where should "[✓] Bookmarks" go? Also, just confirming that the previous design had "Visited Sites" but now it should be "Visited Pages"?

Comment 9

[Ed Lee :Mardak]

Attachment: v1 screenshot

I'll assume bookmarks come after visited for now.

Comment 10

[Ed Lee :Mardak]

Attachment: v1.1 screenshot

Comment 11

[Aaron Benson]

(In reply to Ed Lee :Mardak from comment #10)
> Created attachment 8969160 [details]
> v1.1 screenshot

This looks good to me .. updated the spec!

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4111

Comment 13

[Ed Lee :Mardak]

abenson/nchapman: We're trying to land this feature and strings today for localizers to have time to translate for 61. In particular, is there a preferred wording for "Pocket Saves" and can it be translated as just "Pocket Saved Items" (and should we just use that for en-US?). See attachment 8969160 [details] for a screenshot.

The pocket website doesn't seem to use the term "Saves" for referring to the saved items in "My List". And "Saves" I would guess is tricky to translate as "Save" happens to be the same word for the verb action and the noun describing the result in English.

If there isn't an official term for other languages, we'll just have a note for localizers describing the intent of the string, e.g.,

"Pocket" is a brand name. "Saves" is a plural noun referring to the result of multiple "Save" actions; "Saved Items" can be used instead. Preferably, "Saves" matches up with the primary "Save to Pocket" action for saving a page.

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/8657d4185a031f3bfe925ad767e6653b221b320b
feat(highlights): Add include* prefs to let about:preferences control what gets shown (#4111)

Fix Bug 1432595 - Add section in prefs to turn off parts of Highlights

Comment 15

[Nick Chapman]

Hi Ed,

I had a chat with the rest of the Pocket team, and we'd like to use "Pages Saved to Pocket". It clears up some of the noun/verb problems and aligns with us using "pages" in various contexts instead of items.

Thanks!

Nick

Comment 16

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4114

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/a772240e93f97e05886ca7b3d2e7ce58deb7ad0d
fix(strings): Update pocket highlight option to "Pages Saved to Pocket" (#4114)

Followup Bug 1432595 - Add section in prefs to turn off parts of Highlights

Comment 18

[Aaron Benson]

(In reply to Nick Chapman from comment #15)
> Hi Ed,
> 
> I had a chat with the rest of the Pocket team, and we'd like to use "Pages
> Saved to Pocket". It clears up some of the noun/verb problems and aligns
> with us using "pages" in various contexts instead of items.
> 
> Thanks!
> 
> Nick

Thanks Nick! Spec updated here: https://mozilla.invisionapp.com/share/MFGXGZIG5JD#/screens/280785532_Explainer

Comment 19

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b

Comment 20

[Ed Lee :Mardak]

Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/15

Comment 21

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Build ID 	20180422223305
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have verified that the issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64. All types of Highlight cards can now be individually hidden as seen in the spec from comment 18.