1432657 - Add pocket card type to highlight types

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3975

Comment 2

[Ed Lee :Mardak]

uiwanted: What's the behavior of saving to pocket? Should the doorhanger appear just like bookmarking? What should the card type text be as well as the context menu options for saving/removing? (We'll check with pocket people too.)

Comment 3

[Aaron Benson]

Trello card with InVision spec: https://trello.com/c/sC5SB5mK/179-pocket-saves-in-highlights

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5b5fb32674da9e96aa9267d1c021c6300057e0a1
Bug 1432657 - Add pocket card type to highlight types

https://github.com/mozilla/activity-stream/commit/b033185d8e890938765552d94621e1ba08758989
Merge pull request #3975 from sarracini/bug_1432657

Fix Bug 1432657 - Add pocket card type to highlight types

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/6b64cc96f1b8

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180226230123

I have verified this on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12 with the latest Nightly build (60.0a1) installed. Now after a card is saved to Pocket the "Archive in Pocket" and the "Delete from Pocket" options are displayed in the card's context menu and also the "Bookmark" and "Delete from History" options are removed from it.
Also, if a website is saved to pocket by any means, it will be displayed as a card in the Highlights section with the "Saved to Pocket" subtext.

Comment 7

[Ed Lee :Mardak]

Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/11