1436449 - Rename item_id to pocket_id for clearer way to identify saved Pocket items in NewTabUtils

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ursula Sarracini (:ursula)]

+ while I'm here also fixing some nits that I realized while doing Bug 1432657

Comment 1

[Ursula Sarracini (:ursula)]

Attachment: Bug 1436449 - Rename item_id to pocket_id for clearer way to identify saved Pocket items in NewTabUtils

Review commit: https://reviewboard.mozilla.org/r/218556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218556/

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8949153 [details]
Bug 1436449 - Rename item_id to pocket_id for clearer way to identify saved Pocket items in NewTabUtils

https://reviewboard.mozilla.org/r/218556/#review224938

::: toolkit/modules/NewTabUtils.jsm:1385
(Diff revision 1)
> +   *@returns {Promise} Returns a promise at completion
> +   */
> +  deletePocketEntry(aItemID) {
> +    return new Promise((resolve, reject) => {
> +      pktApi.deleteItem(aItemID, {
> +        success() {

Pretty sure you can do `new Promise((success, error) => deleteItem(…, {success, error})` ?

Comment 3

[Ursula Sarracini (:ursula)]

Comment on attachment 8949153 [details]
Bug 1436449 - Rename item_id to pocket_id for clearer way to identify saved Pocket items in NewTabUtils

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218556/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/474bea93396d
Rename item_id to pocket_id for clearer way to identify saved Pocket items in NewTabUtils r=Mardak

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/474bea93396d