1432813 - Running './mach test' for Marionette complains that './mach marionette-test is deprecated'

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Mark Banner (:standard8)]

I was just testing a marionette based test locally, and I got this failure:

$ ./mach test browser/components/migration/tests/marionette/test_refresh_firefox.py
warning: ./mach marionette-test is deprecated; please use ./mach marionette test

I'm assuming the ./mach test command needs to be updated somewhere.

Comment 1

[Andreas Tolfsen ❲:ato❳]

"./mach test" has to rely on "./mach marionette-test" because it only
supports forwarding to top-level mach commands.  Instead, I would
propose to remove the warning as "marionette-test" is not going away.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1432813 - Remove warning on "./mach marionette-test".

It is not possible to hook "./mach test" up to "./mach marionette test"
because the test flavours system does not allow delegation to subcommands.

Users find it annoying that using "./mach test" causes a warning
to be emitted.  Considering we will not be able to remove "./mach
marionette-test", this patch instead quenches the warning.

Review commit: https://reviewboard.mozilla.org/r/215416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215416/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8945168 [details]
Bug 1432813 - Remove warning on "./mach marionette-test".

https://reviewboard.mozilla.org/r/215416/#review221056

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f503aeea177
Remove warning on "./mach marionette-test". r=maja_zf

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8f503aeea177