Closed Bug 1432944 Opened 2 years ago Closed 2 years ago

Remove all members from nsIDOMElement

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(16 files, 1 obsolete file)

2.05 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
5.84 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
10.86 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
3.02 KB, patch
Details | Diff | Splinter Review
2.86 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
1.86 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
5.66 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
2.69 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
2.54 KB, patch
m_kato
: review+
Details | Diff | Splinter Review
2.20 KB, patch
Details | Diff | Splinter Review
2.24 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
6.28 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
26.04 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
25.70 KB, patch
Details | Diff | Splinter Review
5.53 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
8.78 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
Blocks: 1432977
The only C++ caller doesn't care, and JS callers can't tell that a non-NS_OK success code was returned anyway.

MozReview-Commit-ID: FNhQYR0a9ur
Attachment #8945289 - Flags: review?(m_kato)
The only C++ caller immediately QIs the result anyway, and the exact type
returned doesn't matter for JS callers because the return values are DOM
objects.  This makes it simpler to rejigger the internals to work with nsINode
and Element and whatnot.

MozReview-Commit-ID: 863IDGECqYY
Attachment #8945290 - Flags: review?(m_kato)
MozReview-Commit-ID: EAEzpom7oXo
Attachment #8945291 - Flags: review?(m_kato)
MozReview-Commit-ID: CDnYK194JB9
Attachment #8945294 - Flags: review?(m_kato)
MozReview-Commit-ID: 8rmd120L2BK
Attachment #8945296 - Flags: review?(continuation)
MozReview-Commit-ID: 926Dzqv7Oj4
Attachment #8945297 - Flags: review?(m_kato)
MozReview-Commit-ID: KDeeVkeRmQr
Attachment #8945299 - Flags: review?(continuation)
MozReview-Commit-ID: 6eIdX8iA5Rg
Attachment #8945300 - Flags: review?(continuation)
MozReview-Commit-ID: 2f1vFvRdCPG
Attachment #8945301 - Flags: review?(continuation)
MozReview-Commit-ID: K6w7FR254UC
Attachment #8945303 - Flags: review?(continuation)
MozReview-Commit-ID: 8A1VcWArVcP
Attachment #8945304 - Flags: review?(continuation)
Attachment #8945289 - Flags: review?(m_kato) → review+
Attachment #8945291 - Flags: review?(m_kato) → review+
Attachment #8945290 - Flags: review?(m_kato) → review+
Attachment #8945293 - Flags: review?(m_kato) → review+
Attachment #8945294 - Flags: review?(m_kato) → review+
Attachment #8945295 - Flags: review?(m_kato) → review+
Attachment #8945297 - Flags: review?(m_kato) → review+
Priority: -- → P2
MozReview-Commit-ID: K6w7FR254UC
Attachment #8945861 - Flags: review?(continuation)
Attachment #8945303 - Attachment is obsolete: true
Attachment #8945303 - Flags: review?(continuation)
Attachment #8945296 - Flags: review?(continuation) → review+
Attachment #8945299 - Flags: review?(continuation) → review+
Attachment #8945300 - Flags: review?(continuation) → review+
Comment on attachment 8945301 [details] [diff] [review]
part 11.  Remove nsIDOMElement::GetAttribute

Review of attachment 8945301 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/tree/nsTreeContentView.cpp
@@ +249,5 @@
>                                         nsAString& aProperties)
>  {
> +  IgnoredErrorResult rv;
> +  RefPtr<Element> element = aColumn.GetElement(rv);
> +  

nit: trailing whitespace.
Attachment #8945301 - Flags: review?(continuation) → review+
Attachment #8945304 - Flags: review?(continuation) → review+
Attachment #8945861 - Flags: review?(continuation) → review+
> nit: trailing whitespace.

Fixed.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93c1d149d757
part 1.  Stop returning NS_EDITOR_ELEMENT_NOT_FOUND from nsIHTMLEditor::GetSelectedElement. r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/15f093275a0d
part 2.  Make nsIHTMLEditor.getSelectedElement return nsISupports.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/84d651460f98
part 3.  Take an early return from HTMLEditor::GetSelectedElement when we can.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4336d56112
part 4.  Work with Element, not nsIDOMElement, inside HTMLEditor::GetSelectedElement.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/7587d756a885
part 5.  Remove the now-unused nsIDOMNode overload of HTMLEditUtils::IsLink.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/3524d4390de9
part 6.  Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b200ba1a37e
part 7.  Remove nsIDOMElement's tagName attribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ad723a13ff
part 8.  Remove usage of nsIDOMElement::HasAttribute in editor code.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5250222f3d5
part 9.  Remove nsIDOMElement::HasAttribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/a59431cb28a1
part 10.  Remove nsIDOMElement::SetAttribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/76c001daf265
part 11.  Remove nsIDOMElement::GetAttribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/e723bf17f405
part 12.  Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f01a1eb49c2e
part 13.  Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro.  r=mccr8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.