1432944 - Remove all members from nsIDOMElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Jorg, there will need to be some Thunderbird changes here too.  See https://searchfox.org/comm-central/search?q=-%3ESetAttribute%28&case=true&path=mailnews and https://searchfox.org/comm-central/search?q=-%3EHasAttribute%28&case=true&path=mailnews and https://searchfox.org/comm-central/search?q=-%3EGetAttribute%28&case=true&path=mailnews

Comment 1

[Jorg K (CEST = GMT+2)]

Let's deal with it in the other bug, I've treated most *Attribute() calls already.

Comment 2

[Boris Zbarsky [:bzbarsky]]

No, this is NOT THE SAME as bug 1432603.  This bug is for m-c changes.  I was just giving you a heads-up so you can file Thunderbird bugs however you prefer.

Note that you will NOT be able to land sane GetAttribute changes before the actual patches for this bug land.

Comment 3

[Jorg K (CEST = GMT+2)]

Sorry.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop returning NS_EDITOR_ELEMENT_NOT_FOUND from nsIHTMLEditor::GetSelectedElement

The only C++ caller doesn't care, and JS callers can't tell that a non-NS_OK success code was returned anyway.

MozReview-Commit-ID: FNhQYR0a9ur

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make nsIHTMLEditor.getSelectedElement return nsISupports

The only C++ caller immediately QIs the result anyway, and the exact type
returned doesn't matter for JS callers because the return values are DOM
objects.  This makes it simpler to rejigger the internals to work with nsINode
and Element and whatnot.

MozReview-Commit-ID: 863IDGECqYY

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Take an early return from HTMLEditor::GetSelectedElement when we can

MozReview-Commit-ID: EAEzpom7oXo

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 3 diff -w, way easier to review

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Work with Element, not nsIDOMElement, inside HTMLEditor::GetSelectedElement

MozReview-Commit-ID: 3F1rbPMgkAR

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove the now-unused nsIDOMNode overload of HTMLEditUtils::IsLink

MozReview-Commit-ID: CDnYK194JB9

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable

MozReview-Commit-ID: 4KlppKdzJGy

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: part 7. Remove nsIDOMElement's tagName attribute

MozReview-Commit-ID: 8rmd120L2BK

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: part 8. Remove usage of nsIDOMElement::HasAttribute in editor code

MozReview-Commit-ID: 926Dzqv7Oj4

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 8 diff -w

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: part 9. Remove nsIDOMElement::HasAttribute

MozReview-Commit-ID: KDeeVkeRmQr

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: part 10. Remove nsIDOMElement::SetAttribute

MozReview-Commit-ID: 6eIdX8iA5Rg

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: part 11. Remove nsIDOMElement::GetAttribute

MozReview-Commit-ID: 2f1vFvRdCPG

Comment 17

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 11 diff -w

Comment 18

[Boris Zbarsky [:bzbarsky]]

Attachment: part 12. Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements

MozReview-Commit-ID: K6w7FR254UC

Comment 19

[Boris Zbarsky [:bzbarsky]]

Attachment: part 13. Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro

MozReview-Commit-ID: 8A1VcWArVcP

Comment 20

[Boris Zbarsky [:bzbarsky]]

Attachment: part 12. Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements

MozReview-Commit-ID: K6w7FR254UC

Comment 21

[Andrew McCreight [:mccr8]]

Comment on attachment 8945301 [details] [diff] [review]
part 11.  Remove nsIDOMElement::GetAttribute

Review of attachment 8945301 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/tree/nsTreeContentView.cpp
@@ +249,5 @@
>                                         nsAString& aProperties)
>  {
> +  IgnoredErrorResult rv;
> +  RefPtr<Element> element = aColumn.GetElement(rv);
> +  

nit: trailing whitespace.

Comment 22

[Boris Zbarsky [:bzbarsky]]

> nit: trailing whitespace.

Fixed.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93c1d149d757
part 1.  Stop returning NS_EDITOR_ELEMENT_NOT_FOUND from nsIHTMLEditor::GetSelectedElement. r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/15f093275a0d
part 2.  Make nsIHTMLEditor.getSelectedElement return nsISupports.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/84d651460f98
part 3.  Take an early return from HTMLEditor::GetSelectedElement when we can.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4336d56112
part 4.  Work with Element, not nsIDOMElement, inside HTMLEditor::GetSelectedElement.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/7587d756a885
part 5.  Remove the now-unused nsIDOMNode overload of HTMLEditUtils::IsLink.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/3524d4390de9
part 6.  Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b200ba1a37e
part 7.  Remove nsIDOMElement's tagName attribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ad723a13ff
part 8.  Remove usage of nsIDOMElement::HasAttribute in editor code.  r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5250222f3d5
part 9.  Remove nsIDOMElement::HasAttribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/a59431cb28a1
part 10.  Remove nsIDOMElement::SetAttribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/76c001daf265
part 11.  Remove nsIDOMElement::GetAttribute.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/e723bf17f405
part 12.  Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f01a1eb49c2e
part 13.  Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro.  r=mccr8

Comment 24

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/93c1d149d757
https://hg.mozilla.org/mozilla-central/rev/15f093275a0d
https://hg.mozilla.org/mozilla-central/rev/84d651460f98
https://hg.mozilla.org/mozilla-central/rev/8d4336d56112
https://hg.mozilla.org/mozilla-central/rev/7587d756a885
https://hg.mozilla.org/mozilla-central/rev/3524d4390de9
https://hg.mozilla.org/mozilla-central/rev/2b200ba1a37e
https://hg.mozilla.org/mozilla-central/rev/e7ad723a13ff
https://hg.mozilla.org/mozilla-central/rev/a5250222f3d5
https://hg.mozilla.org/mozilla-central/rev/a59431cb28a1
https://hg.mozilla.org/mozilla-central/rev/76c001daf265
https://hg.mozilla.org/mozilla-central/rev/e723bf17f405
https://hg.mozilla.org/mozilla-central/rev/f01a1eb49c2e