1433209 - Remove unused strings to simplify translating

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

From https://github.com/mozilla/activity-stream/issues/3314

Now that Test Pilot is done development and self destructed in #3143, we can remove unused strings that aren't used or won't be used by the system addon. This makes it easier for locales that haven't finished translating as per #3274 (comment)

>    Yes please. There's one major pro: some locales might have not translated those strings, and will if they decide to start or finish translating AS.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/aea9fdbcfda23914cc062ed4bb194a042af9371c
chore(l10n): Update localization comments based on reviews (#3955)

These following strings are currently unused in 60 and should be removed as part of bug 1433209:
edit_topsites_button_label=Customize your Top Sites section
edit_topsites_showmore_button=Show More
edit_topsites_showless_button=Show Fewer
edit_topsites_done_button=Done
edit_topsites_pin_button=Pin this site
edit_topsites_unpin_button=Unpin this site
edit_topsites_dismiss_button=Dismiss this site

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

This string is currently unused in 60 and should be removed as part of this bug:
edit_topsites_add_button

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/a9345db2d358c808c011f6835e1084f84eec8afd
feat (sections) - remove info option code

The following strings can be removed after Firefox 60:
* section_info_option
* section_info_privacy_notice
* pocket_feedback_header

(Ping Bug 1433209)

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4018

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/1d0e3079ce17b23ac77bd0ec2513205fa9c11dd0
Fix Bug 1433209 - Remove unused strings to simplify translating.

Comment 6

[Ed Lee :Mardak]

This shouldn't have been merged yet.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4c139faa4d4124f44d9aa69fb59e8db203092630
Fix Bug 1433209 - Remove unused strings.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9df46d48a21c

Comment 9

[Ed Lee :Mardak]

String removal landed in https://github.com/mozilla/activity-stream-l10n/pull/13