1445090 - Remove strings that are unused at the end of 61

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

Similar to bug 1433209 that cleaned up at the end of 60. We want to clean up strings once we no longer need to uplift strings to beta (60) -- i.e., after "final locale check".

We should reference this bug when landing commits that makes a string unused but can't remove it yet.

Comment 1

[Ed Lee :Mardak]

[github robot]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/d301c0e31298c803731efd870359c69c58033a65
feat(preferences): Add preferences to about:preferences when it loads (#4015)

Fix Bug 1404890 - Move new tab settings for sections to about:preferences

Bug 1445090 - These strings are probably unused: pocket_description, settings_pane_topstories_options_sponsored, settings_pane_highlights_body2

Comment 2

[Ursula Sarracini (:ursula)]

The following are strings IDs for strings that are unused and should be removed:

settings_pane_header
settings_pane_body2
settings_pane_search_header
settings_pane_search_body
settings_pane_topsites_header
settings_pane_topsites_body
settings_pane_topsites_options_showmore
settings_pane_highlights_header
settings_pane_highlights_options_bookmarks
settings_pane_highlights_options_visited
settings_pane_snippets_header
settings_pane_snippets_body
settings_pane_done_button

Comment 3

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/pull/4111 added a new string "Visited Pages" leaving settings_pane_highlights_options_visited=Visited Sites unused

Comment 4

[Ed Lee :Mardak]

Pretty sure `prefs_restore_defaults_button=Restore Defaults` ended up not being used as it landed as fluent in m-c home-restore-defaults in bug 1417155.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Ed Lee :Mardak from comment #1)
> Fix Bug 1404890 - Move new tab settings for sections to about:preferences
> 
> Bug 1445090 - These strings are probably unused: pocket_description,
> settings_pane_topstories_options_sponsored, settings_pane_highlights_body2

Removing pocket_description.

The settings_pane strings listed above are already gone.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

My mistake, the two settings_pane* strings mentioned above have not yet been removed; I'll remove them as well.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Ursula Sarracini (:ursula) from comment #2)
> The following are strings IDs for strings that are unused and should be
> removed:
> 
> settings_pane_header
> settings_pane_body2

Removing.

> settings_pane_search_header

Already removed.

> settings_pane_search_body

Removing.

> settings_pane_topsites_header

Still used in AboutPreferences.jsm; leaving alone.

> settings_pane_topsites_body
> settings_pane_topsites_options_showmore

Removed.

> settings_pane_highlights_header
> settings_pane_highlights_options_bookmarks

Still used in SectionsManager.jsm; leaving alone.

> settings_pane_highlights_options_visited

Removed.

> settings_pane_snippets_header

Still used in AboutPreferences.jsm; leaving alone.

> settings_pane_snippets_body
> settings_pane_done_button

Removed.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Ed Lee :Mardak from comment #3)
> https://github.com/mozilla/activity-stream/pull/4111 added a new string
> "Visited Pages" leaving settings_pane_highlights_options_visited=Visited
> Sites unused

Already removed.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Ed Lee :Mardak from comment #4)
> Pretty sure `prefs_restore_defaults_button=Restore Defaults` ended up not
> being used as it landed as fluent in m-c home-restore-defaults in bug
> 1417155.

Removing.

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4140

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/f5ffc3fb9f0f5845339d58ee638e84a9172e302a
chore(l10n): remove unused strings to ease l10n work (#4140)

Fix Bug 1445090 - Remove strings that are unused at the end of 61

Comment 12

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a9f5a8dc2e22