1433236 - Pref off RTCRtpReceiver getContributingSources and getSynchronizationSources APIs for 59

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

We had intended to land RTCRtpReceiver getContributingSources and getSynchronizationSources support in 59, but the specification is still in motion. We need to pref them off until the spec settles, and we can update our implementation. The potential for this was foreseen and a pref was already added in bug 1430213, it just needs to be toggled off.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1433236 - pref off rtp sources API

Review commit: https://reviewboard.mozilla.org/r/215704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215704/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8945570 [details]
Bug 1433236 - pref off rtp sources API

https://reviewboard.mozilla.org/r/215704/#review221432

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Please request beta approval.

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8945570 [details]
Bug 1433236 - pref off rtp sources API

Approval Request Comment
[Feature/Bug causing the regression]: 1430255, and other potential changes that have not made it into the spec
[User impact if declined]: We would ship a non-spec conformant API in a way that would be hard to support in the future.
[Is this code covered by automated tests?]: No. The APIs have tests, but there is no test around disabling the APIs.
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It only disables an API being called from JS
[String changes made/needed]:none

Comment 5

[Eric Shepherd [:sheppy]]

Documentation updated; this is now marked as disabled by default.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.