143333 - Transparent Animated GIF rendered laced with garbage pixels

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[James Paige]

Mozilla-trunk build 2002050910 on Linux

The image http://hamsterrepublic.com/img/bobhitjames.gif linked on
http://hamsterrepublic.com/ohrrpgce/ displays incorrectly in the latest trunk
build. it was displaying perfectly with a trunk nightly from last week.

Notice the garbage pixels scattered around the edges, and the failure to clean
up old frames.

Comment 1

[James Paige]

Not happening in Linux trunk build 2002050507

Comment 2

[ArronM (:paper)]

I'm going under the assumpation that this is caused by the fix of Bug 132319.

The gif displays fine on my Win2k 2002050908 build.

If this is Linux-only bug, then I don't know why the patch caused this problem.
 The Bonsai diff can be seen here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=imgContainer.cpp&root=/cvsroot&subdir=mozilla/modules/libpr0n/src&command=DIFF_FRAMESET&rev1=1.27&rev2=1.28

If anyone can see a problem that could cause the FillWithColor to fail for
linux.. any help would be appreciated.

Comment 3

[ArronM (:paper)]

Attachment: [Fix] Update the Image with a copy

Cause: I didn't know GetImageData on Linux returned a copy of the image and not
the real image.

Resolution: Call ImageUpdated after modifying the copy, which will then move
the copy over to the real image.

Comment 4

[tor]

Comment on attachment 83093 [details] [diff] [review]
[Fix] Update the Image with a copy

sr=tor

Comment 5

[Stuart Parmenter]

Comment on attachment 83093 [details] [diff] [review]
[Fix] Update the Image with a copy

r=pavlov

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 7

[James Paige]

Groovy. With Linux trunk build 2002051607, the image
http://hamsterrepublic.com/img/bobhitjames.gif is animating correctly, sans
garbage pixels.

Marking verified.

Comment 8

[Blake Ross]

Comment on attachment 83093 [details] [diff] [review]
[Fix] Update the Image with a copy

marking verbal a=asa

Comment 9

[Blake Ross]

Fixed on branch.

Comment 10

[Terri Preston]

Removing branch keywork fixed1.0.1, I still see garbage pixels using linux
branch build 2002070207