Port the changes from bug 1418076 [Remove nsIDOMHTMLDocument] to comm-central

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: bzbarsky, Assigned: jorgk)

Tracking

unspecified
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The following files are affected:

* editor/ui/composer/content/editorApplicationOverlay.js
* editor/ui/composer/content/editorUtilities.js
* mail/base/content/specialTabs.js

All three of those need to replace instanceof Ci.nsIDOMHTMLDocument with ChromeUtils.getClassName checks.  Also:

* mailnews/compose/src/nsMsgComposeService.cpp
* suite/smile/public/smileIApplication.idl

nsMsgComposeService just has a #include that can go away, I think.  I'm not sure what smileIApplication.idl is used for, if anything.
Assignee

Updated

Last year
Summary: Port the changes from bug 1418076 to comm-central → Port the changes from bug 1418076 [Remove nsIDOMHTMLDocument] to comm-central
Assignee

Comment 1

Last year
FRG, I won't do the SM part, since I can't test that.
Flags: needinfo?(frgrahl)
Assignee

Updated

Last year
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Comment on attachment 8945881 [details] [diff] [review]
1433363-nsIDOMHTMLDocument.patch (v1) WIP

This looks fine.

> Somehow they want to get the URL from the document.

OK, so what?  This bit:

    var aDOMHTMLDoc = GetCurrentEditor().document.QueryInterface(Components.interfaces.nsIDOMHTMLDocument);
    return aDOMHTMLDoc.URL;

Can be rewritten as:

    return GetCurrentEditor().document.URL;

because "URL" is on the Document interface anyway.  Same for the other thing that wants .URL; that QI is just useless noise.
Attachment #8945881 - Flags: feedback?(bzbarsky) → feedback+
Assignee

Comment 4

Last year
I hope you don't mind looking over two more hunks so we're done here.
Attachment #8945881 - Attachment is obsolete: true
Attachment #8945889 - Flags: review?(bzbarsky)
Comment on attachment 8945889 [details] [diff] [review]
1433363-nsIDOMHTMLDocument.patch (v2)

r=me
Attachment #8945889 - Flags: review?(bzbarsky) → review+

Comment 6

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/454c0dee5033
Port bug 1418076: Remove use of nsIDOMHTMLDocument. r=bz
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Assignee

Comment 7

Last year
Thanks Boris.

Fixed indentation and replaced invalid !=== with !== here:
https://hg.mozilla.org/comm-central/rev/454c0dee5033#l3.14
Target Milestone: --- → Thunderbird 60.0
IanN, should I fix smile again or get rid of it? Any add-on which used it is probably broken by now. SeaMonkey no longer uses it.

...
All three of those need to replace instanceof Ci.nsIDOMHTMLDocument with ChromeUtils.getClassName checks.  Also:

smileIApplication.idl is used for, if anything.
Flags: needinfo?(frgrahl) → needinfo?(iann_bugzilla)

Comment 9

Last year
(In reply to Frank-Rainer Grahl (:frg) from comment #8)
> IanN, should I fix smile again or get rid of it? Any add-on which used it is
> probably broken by now. SeaMonkey no longer uses it.
> 
> ...
> All three of those need to replace instanceof Ci.nsIDOMHTMLDocument with
> ChromeUtils.getClassName checks.  Also:
> 
> smileIApplication.idl is used for, if anything.

Let's ditch the smile :(
Flags: needinfo?(iann_bugzilla)
You need to log in before you can comment on or make changes to this bug.