1433373 - Jump to definition button in console does not handle sourcemap

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce:
1. Go to https://simple-webpack.glitch.me/
2. Open the console
3. See the "render()" function logged
4. Click on the "jump to definition" button


Expected results:

The app.jsx tab is open in the debugger

Actual results:

The bundle source is open in the debugger.
In this case the bundle is small and quite readable so it's not really an issue. In other configurations this might be a problem.
Also, if there's a sourcemap file, we should always try to use it and navigate the user to the original file.

Comment 1

[Sebastian Zartner [:sebo]]

Nicolas, am I right that this also fixes jumping to pretty-printed sources as mentioned in https://stackoverflow.com/q/48484273/432681? Or are pretty-printed sources handled differently to source-mapped files?

Sebastian

Comment 2

[Sebastian Zartner [:sebo]]

Second question: What's the bug the "jump to definition" button was implemented? I couldn't find it and wanted to mark it as dev-doc-needed.

Sebastian

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

This was implemented in Reps, which are in Github https://github.com/devtools-html/devtools-core/pull/812, and the hook in the webconsole was added in Bug 1419787.

For the pretty-printed source, I do think it is using sourcemap, but I'm not sure.
I'll check when this bug is fixed.

Comment 4

[mattheww]

Hi, is this bug available?

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Hello Matthew, yes it is :) Are you interested working on it?

Comment 6

[mattheww]

Yes, I'd like to work on it, please. I'm interested in making source maps more transparent in general.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Great, the bug is now yours :)

You can read through https://docs.firefox-dev.tools/getting-started/ to set up everything to work on devtools.

Then, this is the place where we create the jump to definition button devtools/client/debugger/packages/devtools-reps/src/reps/function.js#36-49

You can see that we execute onViewSourceInDebugger which we pass to the React component.
So we need to run the location through a sourcemap service, like we do in https://searchfox.org/mozilla-central/source/devtools/client/shared/components/SmartTrace.js.

You can join us on Slack if you want to discuss anything :)

Comment 8

[mattheww]

Attachment: Bug 1433373 - Use source mapping for console jump to definition button

Comment 9

[mattheww]

Attachment: Bug 1433373 - Use source mapping for console jump to definition button

Bundle changes

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e92d0cd2aaf
Use source mapping for console jump to definition button r=nchevobbe

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4e92d0cd2aaf

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Mattheww, you indicated this bug regressed Bug 1589346, but I don't think it really did?

Comment 13

[mattheww]

You're right, I'm very sorry. It's the same issue but a different regression.