Closed Bug 1433373 Opened 2 years ago Closed 3 months ago
Jump to definition button in console does not handle sourcemap
47 bytes, text/x-phabricator-request
|Details | Review|
Steps to reproduce: 1. Go to https://simple-webpack.glitch.me/ 2. Open the console 3. See the "render()" function logged 4. Click on the "jump to definition" button Expected results: The app.jsx tab is open in the debugger Actual results: The bundle source is open in the debugger. In this case the bundle is small and quite readable so it's not really an issue. In other configurations this might be a problem. Also, if there's a sourcemap file, we should always try to use it and navigate the user to the original file.
Nicolas, am I right that this also fixes jumping to pretty-printed sources as mentioned in https://stackoverflow.com/q/48484273/432681? Or are pretty-printed sources handled differently to source-mapped files? Sebastian
Second question: What's the bug the "jump to definition" button was implemented? I couldn't find it and wanted to mark it as dev-doc-needed. Sebastian
This was implemented in Reps, which are in Github https://github.com/devtools-html/devtools-core/pull/812, and the hook in the webconsole was added in Bug 1419787. For the pretty-printed source, I do think it is using sourcemap, but I'm not sure. I'll check when this bug is fixed.
Assignee: nobody → mattheww
You need to log in before you can comment on or make changes to this bug.