Closed
Bug 1585407
Opened 5 years ago
Closed 5 years ago
setPendingSelectedLocation loses line/column
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: wartmanm, Assigned: wartmanm)
References
Details
Attachments
(1 file)
Steps to reproduce:
- Navigate to devtools/client/webconsole/test/browser/test-click-function-to-mapped-source.html (from bug 1433373)
- Log "foo"
- Click it
You'll be taken to line 0 column 0 of the original file. The position is lost because selectSourceURL passes in the position {line: 9} but setPendingSelectedLocation expects {location: {line: 9}}: https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/actions/sources/select.js#92
Additionally, the SET_PENDING_SELECTED_LOCATION reducer discards the column: https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/sources.js#202
|
||
Updated•5 years ago
|
Priority: -- → P3
|
|
||
Updated•5 years ago
|
Assignee: nobody → wartmanm
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cffcebd1e74b setPendingSelectedLocation loses line/column r=jlast
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•