1585407 - setPendingSelectedLocation loses line/column

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[mattheww]

Steps to reproduce:

1. Navigate to devtools/client/webconsole/test/browser/test-click-function-to-mapped-source.html (from bug 1433373)
2. Log "foo"
3. Click it

You'll be taken to line 0 column 0 of the original file. The position is lost because selectSourceURL passes in the position {line: 9} but setPendingSelectedLocation expects {location: {line: 9}}: https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/actions/sources/select.js#92
Additionally, the SET_PENDING_SELECTED_LOCATION reducer discards the column: https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/sources.js#202

Comment 1

[mattheww]

Attachment: Bug 1585407 - setPendingSelectedLocation loses line/column

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cffcebd1e74b
setPendingSelectedLocation loses line/column r=jlast

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cffcebd1e74b