Closed Bug 1433517 Opened 8 years ago Closed 7 years ago

Fix generate of MOZ_MACBUNDLE_ID

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: arthur, Assigned: arthur)

Details

(Whiteboard: [tor 21723])

Attachments

(1 file)

0001-Bug-1433517-Prevent-illegal-characters-in-MOZ_MACBUN.patch
1.25 KB, patch
glandium
: review+
Details | Diff | Splinter Review
The generation of MOZ_MACBUNDLE_ID does not work for Tor Browser without a patch. Here's Tor Browser's patch: torpat.ch/21723 and here is the original ticket: https://trac.torproject.org/21723
If your main problem for tor browser was with the space, this was recently fixed in bug 1431477.
(stripping more illegal character is a good thing, though, I'm all for taking a rebased version of your patch.
Thanks, glandium! Here's a rebase for review.
Attachment #8948472 - Flags: review?(mh+mozilla)
Attachment #8948472 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7f88998e959 Prevent illegal characters in MOZ_MACBUNDLE_ID r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a7f88998e959
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
Assignee: nobody → arthuredelstein
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: