Closed Bug 1433574 Opened 2 years ago Closed 2 years ago
Remove the addon update check at startup
For Firefox 57 we streamlined the addon update check at start up in bug 1353194. We did this because we felt that there would be a lot of extensions that might not update to the last minute, or they would set there extensions to only update when 57 had gone out. We don't want to keep this around forever as compatability checks are pretty much useless and restartless add-ons are no more. The suggestion was to keep this until after the next ESR. Users who move up to the next ESR (currently 60) will get the benefit of this dialog. So let's aim to remove this in Firefox 61.
Attachment #8970364 - Flags: review?(kmaglione+bmo)
Comment on attachment 8970364 [details] Bug 1433574 Remove startup addon update check https://reviewboard.mozilla.org/r/239152/#review244820 \o/
Attachment #8970364 - Flags: review?(kmaglione+bmo) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cf1022433399 Remove startup addon update check r=kmag
Backed out for causing linux build bustages Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=cf1022433399232d089891e4979fced0289b0e7c Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=175227975&repo=autoland&lineNumber=29984 Backout: https://hg.mozilla.org/integration/autoland/rev/60cf97933726a504197477aab9f8092cf9fd97b5
(In reply to Andreea Pavel [:apavel] from comment #6) > Backed out for causing linux build bustages > > Push that started the failures: > https://treeherder.mozilla.org/#/ > jobs?repo=autoland&revision=cf1022433399232d089891e4979fced0289b0e7c > > Failure log: > https://treeherder.mozilla.org/logviewer. > html#?job_id=175227975&repo=autoland&lineNumber=29984 > > Backout: > https://hg.mozilla.org/integration/autoland/rev/ > 60cf97933726a504197477aab9f8092cf9fd97b5 The same failures occurred on windows too https://treeherder.mozilla.org/logviewer.html#?job_id=175227941&repo=autoland&lineNumber=34880
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b3ef06fe604d Remove startup addon update check r=kmag
Backed out for merge conflicts with Bug 1363925. https://hg.mozilla.org/integration/autoland/rev/52805bf2d0f867b148e7f8e90ac1a3b08dd1ad3d
https://hg.mozilla.org/integration/mozilla-inbound/rev/483a0ccebc285df70c11799d20269859a6a46593 Bug 1433574 Remove startup addon update check r=kmag
Verified as fixed and no update checks are made at start-up.
Status: RESOLVED → VERIFIED
Please note that this patch removed the extensions.showMismatchUI from testing/geckodriver/src/prefs.rs without approval from a module peer. geckodriver is used out-of-tree against all release channels, and removing before the minimum supported Firefox release is 61 will cause backwards compatibility problems. I’m going to revert the change to this file specifically as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1441204.
You need to log in before you can comment on or make changes to this bug.