Closed
Bug 1433654
Opened 7 years ago
Closed 7 years ago
Improve spellcheck icon
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 60.0
People
(Reporter: thomas8, Assigned: Paenglab)
Details
(Keywords: polish)
Attachments
(4 files)
2.25 KB,
image/svg+xml
|
thomas8
:
ui-review+
|
Details |
5.66 KB,
image/png
|
Details | |
4.98 KB,
image/png
|
Details | |
1.53 KB,
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
The new icon for the spellcheck looks too large and one leg of the "A" in the icon is short. I started a talk about this via PM, and Richard has come up with a better icon, which looks a lot better.
Reporter | ||
Comment 1•7 years ago
|
||
Here's a screenshot showing the new icon on top and the current one below.
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8946050 [details]
spelling.svg
Yes, this looks normal now. Nice. This can definitely work.
Have you tried a bigger checkmark?
Attachment #8946050 -
Flags: ui-review+
Reporter | ||
Comment 3•7 years ago
|
||
I have a question though: Was there any need for a new icon at all? The existing icon in the release (a simple checkmark) looks much clearer to me, and less ambiguous. We also have "A" in icons about font, so imho the mental processing load to understand the new icon is bigger than the simple checkmark, combined with the button text ("Spelling"):
> ✓ Spelling
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Thomas D. (currently busy elsewhere) from comment #2)
> Comment on attachment 8946050 [details]
> spelling.svg
>
> Have you tried a bigger checkmark?
The bigger checkmark would hide too much from the "A", to make it not good recognizable as a "A". It looks then almost like a slash.
Comment 5•7 years ago
|
||
I don't like the new spellcheck icon much either. It looks much too big compared to the send icon, and the left leg is too long. Let's ask the original creator.
Flags: needinfo?(ntim.bugs)
Comment 6•7 years ago
|
||
Already answered Richard via email: Looks good to me! Definite improvement :)
Flags: needinfo?(ntim.bugs)
Reporter | ||
Comment 7•7 years ago
|
||
(In reply to Thomas D. (currently busy elsewhere) from comment #3)
> I have a question though: Was there any need for a new icon at all? The
> existing icon in the release (a simple checkmark) looks much clearer to me,
> and less ambiguous. We also have "A" in icons about font, so imho the mental
> processing load to understand the new icon is bigger than the simple
> checkmark, combined with the button text ("Spelling"):
>
> > ✓ Spelling
Before we proceed, any thoughts on this one?
Flags: needinfo?(richard.marti)
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(jorgk)
Comment 8•7 years ago
|
||
(In reply to Thomas D. (currently busy elsewhere) from comment #7)
> > > ✓ Spelling
> Before we proceed, any thoughts on this one?
Well, the "A" with with a little check mark stuck to its right leg seems to be establishing itself as related to dictionaries and spellcheck, see Add-on manager. A check mark along doesn't really relate to spelling, so I'd prefer the "A".
Richard's new proposal looks good.
As a different issue, the icon on the compose toolbar looks OK, in the Add-on manager I see a vertical artefact, is that expected?
Flags: needinfo?(jorgk)
Comment 9•7 years ago
|
||
(In reply to Thomas D. (currently busy elsewhere) from comment #7)
> (In reply to Thomas D. (currently busy elsewhere) from comment #3)
> > I have a question though: Was there any need for a new icon at all? The
> > existing icon in the release (a simple checkmark) looks much clearer to me,
> > and less ambiguous. We also have "A" in icons about font, so imho the mental
> > processing load to understand the new icon is bigger than the simple
> > checkmark, combined with the button text ("Spelling"):
> >
> > > ✓ Spelling
>
> Before we proceed, any thoughts on this one?
Just a checkmark is a bit vague IMO. In the icon, the "A" represents text, and the checkmark represents the fact that it's correct. The relation of both means "correct text", hence spelling.
> As a different issue, the icon on the compose toolbar looks OK, in the Add-on manager I see a vertical artefact, is that expected?
Not sure, I didn't make the icon. Feel free to file an issue here however: https://github.com/FirefoxUX/icons/issues
Flags: needinfo?(ntim.bugs)
Comment 10•7 years ago
|
||
Assignee | ||
Comment 11•7 years ago
|
||
This is the icon I already proposed via mail and which is on the screenshot. It's now only optimized in file size.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #8946309 -
Flags: review?(ntim.bugs)
Updated•7 years ago
|
Attachment #8946309 -
Flags: review?(ntim.bugs) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 12•7 years ago
|
||
Actually Richard, could you please take a look at the answers in https://github.com/FirefoxUX/icons/issues/56. They don't want to change the FF icon used for the download of additional dictionaries.
So perhaps we can make that icon better for ourselves.
Assignee | ||
Comment 13•7 years ago
|
||
The problem of the add-ons- and prefs icons is that they are created as 16px icons and then scaled to 24px. To make them sharp/pixel perfect we'd need 24px icons.
Comment 14•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/beb37e224f04c8bfa18974e4a14806b8e8c3b143
Improve spellcheck icon. r=ntim
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in
before you can comment on or make changes to this bug.
Description
•