1433659 - Thunderbird Daily no longer displays Twitter profile pictures.

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[dadada123]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180118215408

Steps to reproduce:

I downloaded the version of Thunderbird Daily for 27th January 2018.


Actual results:

Thunderbird updated, but the chat view for Twitter is now like the chat view view for IRC. Most users would think this is a bad idea and the change should be reverted.


Expected results:

Either Thunderbird should have made an option for how the chat works and let the user select the old style, or Thunderbird should have kept the old style.

Comment 1

[Richard Marti (:Paenglab)]

The only error I see is

ReferenceError: reference to undefined property "getScriptableHelper"[Learn More]  imAccounts.js:365:22

Comment 2

[dadada123]

Sorry. What I mean is that the Daily version of Thunderbird changed the chat design when a person uses Twitter, and that the previous chat design is more preferable (at least, to me) and the user should be able to revert to the previous design if they wish.

I've provided some pictures below to demontrate what I mean.
New Twitter chat design: https://i.imgur.com/E8UsJs2.png
Old Twitter chat design: https://www.arobase.org/wp-content/uploads/2015/04/thunderbird-twitter3.png

I was hoping for an option to revert to a chat design where pictures are enabled, like the second screenshot.

Thanks for understanding.

Comment 3

[Richard Marti (:Paenglab)]

Back-out of bug 1432966 fixes the issue.

Comment 4

[Patrick Cloke [:clokep]]

(In reply to dadada123 from comment #2)
> Sorry. What I mean is that the Daily version of Thunderbird changed the chat
> design when a person uses Twitter, and that the previous chat design is more
> preferable (at least, to me) and the user should be able to revert to the
> previous design if they wish.

dadada123, Thanks for reporting. This change wasn't made on purpose, so it's not a matter of providing an option, but fixing the bug that forced Twitter to use the other message style. It looks like Richard has found what caused the issue, but it is not yet clear how to fix it!

Comment 5

[dadada123]

(In reply to Patrick Cloke [:clokep] from comment #4)
> (In reply to dadada123 from comment #2)
> > Sorry. What I mean is that the Daily version of Thunderbird changed the chat
> > design when a person uses Twitter, and that the previous chat design is more
> > preferable (at least, to me) and the user should be able to revert to the
> > previous design if they wish.
> 
> dadada123, Thanks for reporting. This change wasn't made on purpose, so it's
> not a matter of providing an option, but fixing the bug that forced Twitter
> to use the other message style. It looks like Richard has found what caused
> the issue, but it is not yet clear how to fix it!

Thankks for simplifying, and to Richard for finding the cause.

Comment 6

[Florian Quèze [:florian]]

Attachment: Patch

I haven't verified that this fixes the twitter images, but it fixes the colors on the Bubbles theme (which rely on the custom senderColor and nickColor attributes). The twitter specific theme relies on the custom prpl attribute: https://searchfox.org/comm-central/source/mail/components/im/messages/mail/main.css#139).

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Florian Quèze [:florian] from comment #6)
> Created attachment 8946485 [details] [diff] [review]
> Patch
> 
> I haven't verified that this fixes the twitter images, but it fixes the
> colors on the Bubbles theme (which rely on the custom senderColor and
> nickColor attributes). The twitter specific theme relies on the custom prpl
> attribute:
> https://searchfox.org/comm-central/source/mail/components/im/messages/mail/
> main.css#139).

The special Twitter styles are used again with this patch.

Comment 8

[Patrick Cloke [:clokep]]

Comment on attachment 8946485 [details] [diff] [review]
Patch

Review of attachment 8946485 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27bb4a90e0a8
disable automatic HTML sanitization when creating document fragments in imThemes.jsm, r=clokep.

Comment 10

[Florian Quèze [:florian]]

Comment on attachment 8946485 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): bug 1432966
User impact if declined: incorrect display of chat messages

We need someone to figure out where bug 1432966 got uplifted, and we need to uplift this fix in the same branches. I'm not sure what that means exactly.

Comment 11

[Jorg K (CEST = GMT+2)]

You didn't set a target milestone when landing the patch. Therefore all uplift requests never showed up in any query :-( - Since that's all water down the bridge, I'll cancel them now.

Comment 12

[Jorg K (CEST = GMT+2)]

Actually, "water under the bridge" ;-)