Closed Bug 1434016 Opened 3 years ago Closed 2 years ago

Inline security manager XUL Overlays

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file)

It appears the following overlays are only used once and could instead be inlined (or included with the preprocessor):

1 	chrome://pippki/content/CAOverlay.xul
1 	chrome://pippki/content/certDump.xul
1 	chrome://pippki/content/MineOverlay.xul
1 	chrome://pippki/content/OrphanOverlay.xul
1 	chrome://pippki/content/OthersOverlay.xul
1 	chrome://pippki/content/viewCertDetails.xul
1 	chrome://pippki/content/WebSitesOverlay.xul
Assignee: nobody → bdahl
Hi Brendan - just a heads up: I'm traveling, so I might not be able to get to these (this and bug 1434151) until Thursday. They look good, but I want to double-check that everything still works (we don't actually have great test coverage for these).
Comment on attachment 8946455 [details]
Bug 1434016 - Inline and remove the various security manager overlays.

https://reviewboard.mozilla.org/r/216402/#review222802

Great - r=me.
Attachment #8946455 - Flags: review?(dkeeler) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8d4238d86645a4ada5994e76dc4e2119a2d0728c -d e70fa2345198: rebasing 445721:8d4238d86645 "Bug 1434016 - Inline and remove the various security manager overlays. r=keeler" (tip)
merging security/manager/pki/resources/jar.mn
warning: conflicts while merging security/manager/pki/resources/jar.mn! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a0141166482
Inline and remove the various security manager overlays. r=keeler
https://hg.mozilla.org/mozilla-central/rev/1a0141166482
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.