1434016 - Inline security manager XUL Overlays

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement)

Description

[Brendan Dahl [:bdahl]]

It appears the following overlays are only used once and could instead be inlined (or included with the preprocessor):

1 	chrome://pippki/content/CAOverlay.xul
1 	chrome://pippki/content/certDump.xul
1 	chrome://pippki/content/MineOverlay.xul
1 	chrome://pippki/content/OrphanOverlay.xul
1 	chrome://pippki/content/OthersOverlay.xul
1 	chrome://pippki/content/viewCertDetails.xul
1 	chrome://pippki/content/WebSitesOverlay.xul

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: Bug 1434016 - Inline and remove the various security manager overlays.

This is part of the work to remove XUL overlays. All of these overlays are
used only once and do not need to be in their own overlay files.

Review commit: https://reviewboard.mozilla.org/r/216402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216402/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Hi Brendan - just a heads up: I'm traveling, so I might not be able to get to these (this and bug 1434151) until Thursday. They look good, but I want to double-check that everything still works (we don't actually have great test coverage for these).

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8946455 [details]
Bug 1434016 - Inline and remove the various security manager overlays.

https://reviewboard.mozilla.org/r/216402/#review222802

Great - r=me.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8d4238d86645a4ada5994e76dc4e2119a2d0728c -d e70fa2345198: rebasing 445721:8d4238d86645 "Bug 1434016 - Inline and remove the various security manager overlays. r=keeler" (tip)
merging security/manager/pki/resources/jar.mn
warning: conflicts while merging security/manager/pki/resources/jar.mn! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 8946455 [details]
Bug 1434016 - Inline and remove the various security manager overlays.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216402/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a0141166482
Inline and remove the various security manager overlays. r=keeler

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1a0141166482