Closed
Bug 1434056
Opened 6 years ago
Closed 6 years ago
Add nightly talos profiling job for Win10
Categories
(Testing :: Talos, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: rwood, Assigned: rwood)
References
Details
(Whiteboard: [PI:March])
Attachments
(2 files, 2 obsolete files)
Bug 1425850 and Bug 1431427 add a new set of talos profiling tests that run on nightly OSX and Linux64. These are the regular talos tests but with geckoProfiling turned on, so we can have nightly talos profiling artifacts. They report in a new treeherder group called "T-P". Now add the same suite on Windows 10. The talos and treeherder changes were all done in the above mentioned bugs, only buildbot configs need to be added for the Windows suite.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Whiteboard: [PI:January]
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8946431 -
Flags: review?(kmoir)
Comment 2•6 years ago
|
||
Comment on attachment 8946431 [details] [diff] [review] bug1434056-bb.patch So when I applied this patch on my buildbot staging instance, the diff includes windows 7 talos tests as well, is that what you expected?
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Kim Moir [:kmoir] ET from comment #2) > Comment on attachment 8946431 [details] [diff] [review] > bug1434056-bb.patch > > So when I applied this patch on my buildbot staging instance, the diff > includes windows 7 talos tests as well, is that what you expected? Thanks Kim! Oh well ideally just Win 10 since talos may not be on Win 7 much longer anyway. To make it Win 10 only would I have to add something like: WIN10_ONLY = get_talos_slave_platforms(PLATFORMS, platforms=('win64')) And then use "WIN10_ONLY" instead of "ALL_TALOS_PLATFORMS" in the profiling entries, would that work?
Flags: needinfo?(kmoir)
Assignee | ||
Updated•6 years ago
|
Attachment #8946431 -
Attachment is obsolete: true
Attachment #8946431 -
Flags: review?(kmoir)
Assignee | ||
Comment 4•6 years ago
|
||
Updated the patch to only run on Win 10 (I think haha)
Flags: needinfo?(kmoir)
Attachment #8946810 -
Flags: review?(kmoir)
Comment 5•6 years ago
|
||
There is a missing closing bracket here on the options line. 'svgr-profiling-e10s': { + 'enable_by_default': False, + 'suites': GRAPH_CONFIG + ['--activeTests', 'tsvgr:tsvgr_opacity', '--filter', 'ignore_first:5', '--filter', 'median'], + 'options': ({}, WIN10_ONLY, + }, There is also this error when running checkconfig, perhaps config_common.py needs to be updated Traceback (most recent call last): File "/builds/buildbot/kmoir/test8/lib/python2.7/site-packages/buildbot-0.8.2_hg_32c39d25fd41_production_0.8-py2.7.egg/buildbot/scripts/runner.py", line 1042, in doCheckConfig ConfigLoader(configFileName=configFileName) File "/builds/buildbot/kmoir/test8/lib/python2.7/site-packages/buildbot-0.8.2_hg_32c39d25fd41_production_0.8-py2.7.egg/buildbot/scripts/checkconfig.py", line 31, in __init__ self.loadConfig(configFile, check_synchronously_only=True) File "/builds/buildbot/kmoir/test8/lib/python2.7/site-packages/buildbot-0.8.2_hg_32c39d25fd41_production_0.8-py2.7.egg/buildbot/master.py", line 652, in loadConfig exec f in localDict File "/builds/buildbot/kmoir/test8/master/master.cfg", line 10, in <module> import config File "/tmp/tmp80ggBb/config.py", line 294, in <module> File "/tmp/tmp80ggBb/config_common.py", line 79, in get_talos_slave_platforms KeyError: 'w'
Assignee | ||
Updated•6 years ago
|
Attachment #8946810 -
Attachment is obsolete: true
Attachment #8946810 -
Flags: review?(kmoir)
Assignee | ||
Comment 6•6 years ago
|
||
Thanks Kim! Ah, the platforms parameter is a tuple so I had to add a comma after the single entry for WIN10_ONLY.
Attachment #8947120 -
Flags: review?(kmoir)
Updated•6 years ago
|
Attachment #8947120 -
Flags: review?(kmoir) → review+
Assignee | ||
Comment 7•6 years ago
|
||
Thanks Kim! Landed in buildbot-configs: https://hg.mozilla.org/build/buildbot-configs/rev/23629646c6b624cadf34c31751aafdac75c044c2
Comment 8•6 years ago
|
||
It needs to land on the production branch in order to be enabled on the masters. Do you have rights to merge to that branch or would you like me to do that?
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to Kim Moir [:kmoir] ET from comment #8) > It needs to land on the production branch in order to be enabled on the > masters. Do you have rights to merge to that branch or would you like me to > do that? No I have never done that so assuming I do not, if you could please that'd be great, thanks Kim!
Comment 10•6 years ago
|
||
okay merged
Assignee | ||
Comment 11•6 years ago
|
||
Thanks Kim!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•6 years ago
|
||
The buildbot configs didn't seem to take, at least the new talos profiling job (T-P-e10s) is not showing up on central on Win 10. Depending on the status of the new talos / tc windows migration, we'll revisit this again next week and maybe we can just move this job to taskcluster at that time.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [PI:January] → [PI:February]
Assignee | ||
Comment 13•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28cb733b9d8ea7a75b4f94bc5d47e383816a080
Assignee | ||
Comment 14•6 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #13) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28cb733b9d8ea7a75b4f94bc5d47e383816a080 Tried this on existing/old hw by mistake). *** Can't land this until the Windows switchover to taskcluster (& the new h/w) is complete.
Comment hidden (mozreview-request) |
Comment 16•6 years ago
|
||
mozreview-review |
Comment on attachment 8949917 [details] Bug 1434056 - Add nightly talos profiling job for Win10; https://reviewboard.mozilla.org/r/219220/#review225010 thanks!
Attachment #8949917 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 17•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=434162b67be968fd4fca734dba40429f469cdc4e
Assignee | ||
Comment 18•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=21f01ded7c959ce045d7ef5580ffad0d09b07b53
Assignee | ||
Comment 19•6 years ago
|
||
Note to self: Also add the motionmark-profiling job to this nighty suite, it's landing in Bug 1436726
Depends on: 1436726
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Whiteboard: [PI:February] → [PI:March]
Comment hidden (mozreview-request) |
Assignee | ||
Comment 23•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1a79017c233c381ccf81f628c8138faf94df310
Comment 24•6 years ago
|
||
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4a3e7fb39f7 Add nightly talos profiling job for Win10; r=jmaher
Comment 25•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4a3e7fb39f7
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•