1434056 - Add nightly talos profiling job for Win10

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Robert Wood [:rwood]]

Bug 1425850 and Bug 1431427 add a new set of talos profiling tests that run on nightly OSX and Linux64. These are the regular talos tests but with geckoProfiling turned on, so we can have nightly talos profiling artifacts. They report in a new treeherder group called "T-P".

Now add the same suite on Windows 10. The talos and treeherder changes were all done in the above mentioned bugs, only buildbot configs need to be added for the Windows suite.

Comment 1

[Robert Wood [:rwood]]

Attachment: bug1434056-bb.patch

Comment 2

[Kim Moir [:kmoir] ET]

Comment on attachment 8946431 [details] [diff] [review]
bug1434056-bb.patch

So when I applied this patch on my buildbot staging instance, the diff includes windows 7 talos tests as well, is that what you expected?

Comment 3

[Robert Wood [:rwood]]

(In reply to Kim Moir [:kmoir] ET from comment #2)
> Comment on attachment 8946431 [details] [diff] [review]
> bug1434056-bb.patch
> 
> So when I applied this patch on my buildbot staging instance, the diff
> includes windows 7 talos tests as well, is that what you expected?

Thanks Kim! Oh well ideally just Win 10 since talos may not be on Win 7 much longer anyway. To make it Win 10 only would I have to add something like:

WIN10_ONLY = get_talos_slave_platforms(PLATFORMS, platforms=('win64'))

And then use "WIN10_ONLY" instead of "ALL_TALOS_PLATFORMS" in the profiling entries, would that work?

Comment 4

[Robert Wood [:rwood]]

Attachment: bug1434056-bb-take2.patch

Updated the patch to only run on Win 10 (I think haha)

Comment 5

[Kim Moir [:kmoir] ET]

There is a missing closing bracket here on the options line. 

    'svgr-profiling-e10s': {
+        'enable_by_default': False,
+        'suites': GRAPH_CONFIG + ['--activeTests', 'tsvgr:tsvgr_opacity', '--filter', 'ignore_first:5', '--filter', 'median'],
+        'options': ({}, WIN10_ONLY,
+    },

There is also this error when running checkconfig, perhaps config_common.py needs to be updated

Traceback (most recent call last):
  File "/builds/buildbot/kmoir/test8/lib/python2.7/site-packages/buildbot-0.8.2_hg_32c39d25fd41_production_0.8-py2.7.egg/buildbot/scripts/runner.py", line 1042, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/builds/buildbot/kmoir/test8/lib/python2.7/site-packages/buildbot-0.8.2_hg_32c39d25fd41_production_0.8-py2.7.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/builds/buildbot/kmoir/test8/lib/python2.7/site-packages/buildbot-0.8.2_hg_32c39d25fd41_production_0.8-py2.7.egg/buildbot/master.py", line 652, in loadConfig
    exec f in localDict
  File "/builds/buildbot/kmoir/test8/master/master.cfg", line 10, in <module>
    import config
  File "/tmp/tmp80ggBb/config.py", line 294, in <module>
  File "/tmp/tmp80ggBb/config_common.py", line 79, in get_talos_slave_platforms
KeyError: 'w'

Comment 6

[Robert Wood [:rwood]]

Attachment: bug1434056-bb-take3.patch

Thanks Kim!

Ah, the platforms parameter is a tuple so I had to add a comma after the single entry for WIN10_ONLY.

Comment 7

[Robert Wood [:rwood]]

Thanks Kim! Landed in buildbot-configs:

https://hg.mozilla.org/build/buildbot-configs/rev/23629646c6b624cadf34c31751aafdac75c044c2

Comment 8

[Kim Moir [:kmoir] ET]

It needs to land on the production branch in order to be enabled on the masters.  Do you have rights to merge to that branch or would you like me to do that?

Comment 9

[Robert Wood [:rwood]]

(In reply to Kim Moir [:kmoir] ET from comment #8)
> It needs to land on the production branch in order to be enabled on the
> masters.  Do you have rights to merge to that branch or would you like me to
> do that?

No I have never done that so assuming I do not, if you could please that'd be great, thanks Kim!

Comment 10

[Kim Moir [:kmoir] ET]

okay merged

Comment 11

[Robert Wood [:rwood]]

Thanks Kim!

Comment 12

[Robert Wood [:rwood]]

The buildbot configs didn't seem to take, at least the new talos profiling job (T-P-e10s) is not showing up on central on Win 10. Depending on the status of the new talos / tc windows migration, we'll revisit this again next week and maybe we can just move this job to taskcluster at that time.

Comment 13

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28cb733b9d8ea7a75b4f94bc5d47e383816a080

Comment 14

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28cb733b9d8ea7a75b4f94bc5d47e383816a080

Tried this on existing/old hw by mistake).

*** Can't land this until the Windows switchover to taskcluster (& the new h/w) is complete.

Comment 15

[Robert Wood [:rwood]]

Attachment: Bug 1434056 - Add nightly talos profiling job for Win10;

Review commit: https://reviewboard.mozilla.org/r/219220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219220/

Comment 16

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8949917 [details]
Bug 1434056 - Add nightly talos profiling job for Win10;

https://reviewboard.mozilla.org/r/219220/#review225010

thanks!

Comment 17

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=434162b67be968fd4fca734dba40429f469cdc4e

Comment 18

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21f01ded7c959ce045d7ef5580ffad0d09b07b53

Comment 19

[Robert Wood [:rwood]]

Note to self: Also add the motionmark-profiling job to this nighty suite, it's landing in Bug 1436726

Comment 20

[Robert Wood [:rwood]]

Comment on attachment 8949917 [details]
Bug 1434056 - Add nightly talos profiling job for Win10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219220/diff/1-2/

Comment 21

[Robert Wood [:rwood]]

Comment on attachment 8949917 [details]
Bug 1434056 - Add nightly talos profiling job for Win10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219220/diff/2-3/

Comment 22

[Robert Wood [:rwood]]

Comment on attachment 8949917 [details]
Bug 1434056 - Add nightly talos profiling job for Win10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219220/diff/3-4/

Comment 23

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1a79017c233c381ccf81f628c8138faf94df310

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4a3e7fb39f7
Add nightly talos profiling job for Win10; r=jmaher

Comment 25

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e4a3e7fb39f7