Closed
Bug 1436726
Opened 8 years ago
Closed 8 years ago
ensure gecko profiling works for new tests like stylebench and motionmark
Categories
(Testing :: Talos, enhancement)
Testing
Talos
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [PI:February])
Attachments
(1 file)
|
8.28 KB,
patch
|
rwood
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Comment 1•8 years ago
|
||
I don't see 'stylebench' in the speedometer-profiling-e10s job definition:
https://searchfox.org/mozilla-central/source/testing/talos/talos.json#92
but...on mozilla-central, I see the T-P(...) jobs run and the sp job has artifacts for both speedometer.zip and stylebench.zip.
Is it possible that we don't need the definitions for <suite>-profiling-e10s? I also cannot run them on try.
| Assignee | ||
Comment 2•8 years ago
|
||
speedometer-profiling-e10s calls the speedometer-e10s suite with --geckoProfile, so this explains my confusion. I can run on try with:
./mach try fuzzy -q 'profiling-e10s' --full
| Assignee | ||
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8953471 [details] [diff] [review]
ensure motionmark has profiling option and cleanup a bit
Review of attachment 8953471 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome! R+ with the one change noted
::: taskcluster/ci/test/talos.yml
@@ +308,5 @@
> - --webServer,localhost
>
> +talos-motionmark-profiling:
> + description: "Talos profiling motionmark"
> + try-name: motionmark
try-name: motionmark-profiling
Attachment #8953471 -
Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b739a29db88e
ensure gecko profiling works for new tests like stylebench and motionmark. r=rwood
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•