1434526 - Failed to build Gecko Profiler on linux/arm

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P5)

Description

[Takuro Ashie [:ashie]]

After bug1433775 was landed, I met the following build error on Yocto-2.0 (for Renesas RZ/G1M) with gcc-4.9 & binutils 2.25.1:

>  0:07.59 {standard input}: Assembler messages:
>  0:07.59 {standard input}:349: Error: bad expression -- `b #_ZL14SigprofHandleriP9siginfo_tPv'
>  0:10.28 /home/aho/Projects/iwg20m-bsp-2.0/build-gcc4.9/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/firefox/git-r0/git/config/rules.mk:1047: recipe for target 'Unified_cpp_tools_profiler0.o' failed
>  0:10.28 make[4]: *** [Unified_cpp_tools_profiler0.o] Error 1

at following lines:

  * https://dxr.mozilla.org/mozilla-central/rev/474d58c9137360c0fa1c85cdd11e3313b33b7cad/mfbt/LinuxSignal.h#28
  * https://dxr.mozilla.org/mozilla-central/rev/474d58c9137360c0fa1c85cdd11e3313b33b7cad/tools/profiler/core/platform-linux-android.cpp#218

It seems that it's concerned with bug1238661.
I succeeded to build it when I revert the fix in bug1238661.

Comment 1

[tt_1]

I can confirm the compile error, now will try again with revert of patch from bug1238661

Comment 2

[tt_1]

With the patch reverted from #1238661, the build continues and is successfull. With gcc-7.3 and binutils-2.29.1 on my end, also did a bit of runtime testing with success.

Comment 3

[tt_1]

The problem seems to be that bug1238661 works around a bug in clang, so by reverting it the build with gcc can be fixed whereas it breaks again the build with clang. Pick your poison!

Comment 4

[Gabriele Svelto [:gsvelto]]

We could always special-case this with #ifdefs. Not pretty but doable.

Comment 6

[Mike Hommey [:glandium]]

Since bug 1463035 is blocked on Android tests using newer emulator images, let's go with a lighter version of it that can land now.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1434526 - Make MOZ_SIGNAL_TRAMPOLINE Android-only.

Bug 1463035 exists to remove it entirely, because as mentioned in bug
1238661 comment 4, we don't actually need this workaround anymore. But
that bug has been blocked for a while because the Android emulator
images we use for testing, for some reason, use a kernel older than any
real device using the same version of Android would use.

Let's however fix the problems it causes with GCC on non-Android ARM
Linux by making it Android-only, rather than removing it entirely.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e6586172fd
Make MOZ_SIGNAL_TRAMPOLINE Android-only. r=gsvelto

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a8e6586172fd