Closed Bug 1434547 Opened 2 years ago Closed 2 years ago

Port bug 1434401 to TB: Remove the "root-element" binding from :root and instead create the LightweightThemeConsumer from JS when new windows are created

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1434401 removes the "root-element" binding.
Attached patch root-element.patch (obsolete) — Splinter Review
I'm going the same way with JS instead of moving the binding. Naturally this needs bug 1434401 applied first to work (I tried it also without and the LW-themes still worked).

Bug 1434401 is not yet landed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8947016 - Flags: review?(jorgk)
Updated after the Cu Ci patches.

Waiting to ask r? until the m-c bug goes further.
Attachment #8947016 - Attachment is obsolete: true
Attachment #8947016 - Flags: review?(jorgk)
Comment on attachment 8949113 [details] [diff] [review]
root-element.patch

Bug 1434401 is in autoland now. So it makes sense to review it. I haven't changed like the FX bug to onLoad because we theme not only the main window but also the AB and the composer window. And so it makes sense to still check for the lightweightthemes="true" to apply only on themeable windows.
Attachment #8949113 - Flags: review?(jorgk)
Comment on attachment 8949113 [details] [diff] [review]
root-element.patch

OK. I played with this a little bit, and the notification chrome-document-global-created fires a lot. The hasAttribute("lightweightthemes") takes care of things, I tested that, too. So all good to go.
Attachment #8949113 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/87cad73c874a
Port bug 1434401 to TB: Remove the "root-element" binding from :root and instead create the LightweightThemeConsumer from JS when new windows are created. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.