1434570 - Port Bug 1434401 to SeaMonkey "Remove the "root-element" binding"

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

I think just changing nsSuiteglue.js is it. Also see TB bug 1434547.


+++ This bug was initially created as a clone of Bug #1434401 +++

We have a binding "root-element" (https://bgrins.github.io/xbl-analysis/tree/#root-element), which gets bound onto the :root XUL element in minimal-xul.css (https://dxr.mozilla.org/mozilla-central/rev/474d58c9137360c0fa1c85cdd11e3313b33b7cad/toolkit/content/minimal-xul.css#33).

The binding basically looks for the "lightweightthemes" attribute on the root element and if it exists it sets up LightweightThemeConsumer instance. I think there’s a pretty good alternative to doing this via XBL which is listen for the "chrome-document-global-created" notification and do the same check / setup from there. Or sticking it in browser.js, given that's the only window we currently use this feature on in Firefox.

This binding is also extended by "dialog" "wizard" bindings, but I can't find any time where anything other than a <window> element gets the "lightweightthemes" attr.  In fact, in m-c the only instance of this is browser.xul (c-c does have quite a few hits but it's always applied to <window> elements so the same change should work there as well):

* https://searchfox.org/mozilla-central/search?q=lightweightthemes%3D&path=
* https://searchfox.org/comm-central/search?q=lightweightthemes%3D&path=

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1434570-lwt-suite-257.patch

Patch from Bill r/a+ from me.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/01c883bca53a
Fix Lightweight themes in suite. r=frg