1434813 - Fix integer overflow of places.database.lastMaintenance in testing/talos/talos/config.py

Status: RESOLVED FIXED

(Testing :: Talos, defect, P2)

Description

[Nicholas Nethercote [inactive]]

testing/talos/talos/config.py has exactly the same problem I fixed in bug 1424030.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. .

Bug 1383896 added this constant to testing/talos/talos/config.py:

> FAR_IN_FUTURE = 7258114800

which is used as the value for the "places.database.lastMaintenance" pref.
(7258114800 seconds after 1970 is the start of the year 2200.)

 libpref stores integers prefs as int32_t and the current parser doesn't detect
overflow. So this overflows to -1331819792. (I detected this with the new prefs
parser from bug 1423840, which does detect integer overflow.) As a result the
condition testing this pref in
toolkit/components/places/PlacesCategoriesStarter.js ends up always succeeding
in tests, which is the exact opposite of what was intended. This patch changes
it to 2147483647 (the year 2038), the maximum int32_t value.

(Note: this is much the same as bug 1424030, which was fixed recently.)

Review commit: https://reviewboard.mozilla.org/r/217082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217082/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8947346 [details]
Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. .

https://reviewboard.mozilla.org/r/217082/#review222912

I like the coincidence of this needing a fix the same day I read this on irc:
<mccr8> Variable of the day: FAR_IN_FUTURE

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ce3cd892a796726d4a7077b705204d1c9a30b0
Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. r=glandium.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a9ce3cd892a7