1434869 - Tidy up no-unused-vars definitions & anything else related to Ci/Cu/Cr/Cc usage in ESLint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P3)

Description

[Mark Banner (:standard8)]

no-unused-vars has various whitelists - generally for `Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS`, but also a few other things in places.

With the work going on in bug 1432992 we should be able to remove the C* ones.

Additionally, I think now that jsms have their own environment, we should be able to either whitelist EXPORTED_SYMBOLS just for jsms, or refine it in some manner so that we don't need to list it everywhere.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. .

Review commit: https://reviewboard.mozilla.org/r/225296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225296/

Comment 2

[Mark Banner (:standard8)]

The patch here cleans up the no-unused-vars definitions for the varsIgnorePattern.

There's a few definitions of no-unused-vars that are in source files that could also be done in other/improved ways, but I'd like to leave those to follow-up bugs that I'll file in the relevant components for developer awareness.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8956408 [details]
Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. .

https://reviewboard.mozilla.org/r/225296/#review231274

Nice! :-)

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8956408 [details]
Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. .

https://reviewboard.mozilla.org/r/225296/#review231276

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54052450edd9
Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/54052450edd9