Closed Bug 1434869 Opened 2 years ago Closed 2 years ago

Tidy up no-unused-vars definitions & anything else related to Ci/Cu/Cr/Cc usage in ESLint

Categories

(Firefox Build System :: Lint and Formatting, enhancement, P3)

3 Branch
enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

no-unused-vars has various whitelists - generally for `Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS`, but also a few other things in places.

With the work going on in bug 1432992 we should be able to remove the C* ones.

Additionally, I think now that jsms have their own environment, we should be able to either whitelist EXPORTED_SYMBOLS just for jsms, or refine it in some manner so that we don't need to list it everywhere.
Depends on: 1440379
Product: Testing → Firefox Build System
Assignee: nobody → standard8
Status: NEW → ASSIGNED
The patch here cleans up the no-unused-vars definitions for the varsIgnorePattern.

There's a few definitions of no-unused-vars that are in source files that could also be done in other/improved ways, but I'd like to leave those to follow-up bugs that I'll file in the relevant components for developer awareness.
Comment on attachment 8956408 [details]
Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. .

https://reviewboard.mozilla.org/r/225296/#review231274

Nice! :-)
Comment on attachment 8956408 [details]
Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. .

https://reviewboard.mozilla.org/r/225296/#review231276
Attachment #8956408 - Flags: review?(florian) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54052450edd9
Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
https://hg.mozilla.org/mozilla-central/rev/54052450edd9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.