Rendering of system-installed variation fonts on macOS is broken with webrender enabled

RESOLVED FIXED in Firefox 60

Status

()

defect
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: jfkthame, Assigned: lsalzman)

Tracking

(Blocks 1 bug, {regression})

Trunk
mozilla60
Unspecified
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox58 disabled, firefox59 disabled, firefox60 fixed)

Details

(Whiteboard: [gfx-noted])

Reporter

Description

Last year
When gfx.webrender.enabled is set to true, and variation font support is enabled (layout.css.font-variations.enabled:true), the system-installed variation fonts on macOS fail to render properly if any variation settings are applied. (Downloadable fonts continue to work, however.)

STR: enable variation fonts and webrender. Load https://www.axis-praxis.org/, and choose the "Old Default" sample from the list on the left. Note how most of the text is missing.

This used to work; mozregression indicates it was broken by bug 1403198.
Assignee

Comment 1

Last year
To properly fix this we need to pass in the variations dictionary to the CTFont. This requires changes to core-text-rs and webrender. Then we'll have to pull in an updated webrender for the fix to finally get to us.

Initial core-text PR in progress: https://github.com/servo/core-foundation-rs/pull/193
Assignee

Comment 2

Last year
Got the change merged into core-text-rs. Now we just need to fix webrender itself with this PR: https://github.com/servo/webrender/pull/2386
Assignee

Updated

Last year
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
OS: Unspecified → Mac OS X
Priority: P2 → P1
Whiteboard: [gfx-noted]
Assignee

Comment 3

Last year
Merged into WR now. Just need to wait till WR updates, and this should be good.
Depends on: 1436058
Assignee

Updated

Last year
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.