Closed Bug 1435062 Opened 7 years ago Closed 7 years ago

Rendering of system-installed variation fonts on macOS is broken with webrender enabled

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Platform:
Unspecified
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- disabled
firefox59 --- disabled
firefox60 --- fixed

People

(Reporter: jfkthame, Assigned: lsalzman)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

When gfx.webrender.enabled is set to true, and variation font support is enabled (layout.css.font-variations.enabled:true), the system-installed variation fonts on macOS fail to render properly if any variation settings are applied. (Downloadable fonts continue to work, however.) STR: enable variation fonts and webrender. Load https://www.axis-praxis.org/, and choose the "Old Default" sample from the list on the left. Note how most of the text is missing. This used to work; mozregression indicates it was broken by bug 1403198.
To properly fix this we need to pass in the variations dictionary to the CTFont. This requires changes to core-text-rs and webrender. Then we'll have to pull in an updated webrender for the fix to finally get to us. Initial core-text PR in progress: https://github.com/servo/core-foundation-rs/pull/193
Got the change merged into core-text-rs. Now we just need to fix webrender itself with this PR: https://github.com/servo/webrender/pull/2386
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
OS: Unspecified → Mac OS X
Priority: P2 → P1
Whiteboard: [gfx-noted]
Merged into WR now. Just need to wait till WR updates, and this should be good.
Depends on: 1436058
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.