Closed
Bug 1435090
Opened 3 years ago
Closed 3 years ago
Hide the 'persist logs' checkbox when in the Browser Console
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bgrins, Assigned: nchevobbe)
References
Details
(Whiteboard: [newconsole-mvp])
Attachments
(3 files)
There's no reloads happening in the Browser Console, so the checkbox doesn't do anything
Reporter | ||
Comment 1•3 years ago
|
||
There's a patch with the basic idea in https://reviewboard.mozilla.org/r/217368/diff/1#index_header, but it needs tests
Updated•3 years ago
|
Priority: -- → P2
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•3 years ago
|
||
Here's how it looks (I really like having the new frontend in the browser console :) ) Not sure we should add a mochitest for that since it's pretty simple, and we do have a mocha test for the filterBar rendering.
Comment 5•3 years ago
|
||
mozreview-review |
Comment on attachment 8949366 [details] Bug 1435090 - Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; . https://reviewboard.mozilla.org/r/218718/#review224540 Looks good, thanks! R+, assuming try is green Honza ::: devtools/client/webconsole/new-console-output/components/FilterBar.js:224 (Diff revision 1) > const { > filter, > filterBarVisible, > persistLogs, > filteredMessagesCount, > + hidePersistLogsCheckbox = false, nit: you might want to use defaultProps, so it's consistent with other components. static get defaultProps() { return { hidePersistLogsCheckbox: false, }; }
Attachment #8949366 -
Flags: review?(odvarko) → review+
Comment 6•3 years ago
|
||
mozreview-review |
Comment on attachment 8949367 [details] Bug 1435090 - Hide the persist logs checkbox on the browser console; . https://reviewboard.mozilla.org/r/218720/#review224542 R+ Honza
Attachment #8949367 -
Flags: review?(odvarko) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28bcec297b6c Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; r=Honza. https://hg.mozilla.org/integration/autoland/rev/dfd0afe71bb5 Hide the persist logs checkbox on the browser console; r=Honza.
Comment 10•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/28bcec297b6c https://hg.mozilla.org/mozilla-central/rev/dfd0afe71bb5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•3 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•