Hide the 'persist logs' checkbox when in the Browser Console

RESOLVED FIXED in Firefox 60

Status

P1
normal
RESOLVED FIXED
a year ago
9 months ago

People

(Reporter: bgrins, Assigned: nchevobbe)

Tracking

Trunk
Firefox 60
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(3 attachments)

(Reporter)

Description

a year ago
There's no reloads happening in the Browser Console, so the checkbox doesn't do anything
(Reporter)

Updated

a year ago
Depends on: 1435084
Whiteboard: [newconsole-mvp]
(Reporter)

Comment 1

a year ago
There's a patch with the basic idea in https://reviewboard.mozilla.org/r/217368/diff/1#index_header, but it needs tests
Priority: -- → P2
(Assignee)

Updated

a year ago
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 4

a year ago
Here's how it looks (I really like having the new frontend in the browser console :) )

Not sure we should add a mochitest for that since it's pretty simple, and we do have a mocha test for the filterBar rendering.
Comment on attachment 8949366 [details]
Bug 1435090 - Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; .

https://reviewboard.mozilla.org/r/218718/#review224540

Looks good, thanks!

R+, assuming try is green

Honza

::: devtools/client/webconsole/new-console-output/components/FilterBar.js:224
(Diff revision 1)
>      const {
>        filter,
>        filterBarVisible,
>        persistLogs,
>        filteredMessagesCount,
> +      hidePersistLogsCheckbox = false,

nit: you might want to use defaultProps, so it's consistent with other components.

static get defaultProps() {
  return {
    hidePersistLogsCheckbox: false,
  };
}
Attachment #8949366 - Flags: review?(odvarko) → review+
Comment on attachment 8949367 [details]
Bug 1435090 - Hide the persist logs checkbox on the browser console; .

https://reviewboard.mozilla.org/r/218720/#review224542

R+

Honza
Attachment #8949367 - Flags: review?(odvarko) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

a year ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28bcec297b6c
Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/dfd0afe71bb5
Hide the persist logs checkbox on the browser console; r=Honza.

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28bcec297b6c
https://hg.mozilla.org/mozilla-central/rev/dfd0afe71bb5
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.