1435090 - Hide the 'persist logs' checkbox when in the Browser Console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

There's no reloads happening in the Browser Console, so the checkbox doesn't do anything

Comment 1

[Brian Grinstead [:bgrins]]

There's a patch with the basic idea in https://reviewboard.mozilla.org/r/217368/diff/1#index_header, but it needs tests

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1435090 - Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; .

This will allow us to hide the input for the browser console.

Review commit: https://reviewboard.mozilla.org/r/218718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218718/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1435090 - Hide the persist logs checkbox on the browser console; .

Review commit: https://reviewboard.mozilla.org/r/218720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218720/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Screenshot at Feb 08 15-32-11.png

Here's how it looks (I really like having the new frontend in the browser console :) )

Not sure we should add a mochitest for that since it's pretty simple, and we do have a mocha test for the filterBar rendering.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8949366 [details]
Bug 1435090 - Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; .

https://reviewboard.mozilla.org/r/218718/#review224540

Looks good, thanks!

R+, assuming try is green

Honza

::: devtools/client/webconsole/new-console-output/components/FilterBar.js:224
(Diff revision 1)
>      const {
>        filter,
>        filterBarVisible,
>        persistLogs,
>        filteredMessagesCount,
> +      hidePersistLogsCheckbox = false,

nit: you might want to use defaultProps, so it's consistent with other components.

static get defaultProps() {
  return {
    hidePersistLogsCheckbox: false,
  };
}

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8949367 [details]
Bug 1435090 - Hide the persist logs checkbox on the browser console; .

https://reviewboard.mozilla.org/r/218720/#review224542

R+

Honza

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949366 [details]
Bug 1435090 - Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218718/diff/1-2/

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949367 [details]
Bug 1435090 - Hide the persist logs checkbox on the browser console; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218720/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28bcec297b6c
Allow to pass a hidePersistLogsCheckbox prop to the FilterBar; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/dfd0afe71bb5
Hide the persist logs checkbox on the browser console; r=Honza.

Comment 10

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/28bcec297b6c
https://hg.mozilla.org/mozilla-central/rev/dfd0afe71bb5