14354 - UI and backend support for non-default ports

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

we need to add to our account setup and account wizard ui to allow users to
enter non-default ports for pop,nntp,imap server NOT on the default ports.

obviously, there is some backend work that needs to be done here.

in addition, we have to make it so when you migrate from 4.x this gets info gets
migrated properly

Comment 1

[Alec Flett]

I vote for post-PR1 :)
The wizard should not have the port settings, as we're trying to keep that as
simple as possible. But it definately needs to go into the account setup pane.

Comment 2

[Phil Peterson]

Reassign to alecf for M15

Comment 3

[Scott MacGregor]

I'll implement the protocol back end support for this Alec. Just ping me when
you go to work on it and I'll help out.

Comment 4

[(not reading, please use [e-mail] instead)]

adding dependencies.

Comment 5

[(not reading, please use [e-mail] instead)]

adding dependency

Comment 6

[Alec Flett]

attaching a patch for IMAP port support and adding pav to CC because he cares

Comment 7

[Alec Flett]

Attachment: IMAP port support patch

Comment 8

[Alec Flett]

we still need to add support for protocol-type port defaults so we don't have to
hardcode it in every port... this will be added to nsIMsgProtocolInfo, like
defaultLocalPath is.

Comment 9

[Alec Flett]

oops, this is already in nsIProtocolHandler, we should leverage that.

Comment 10

[Scott MacGregor]

r=mscott in case you needed a review.

Comment 11

[Alec Flett]

ok, the IMAP port support has gone in.

Comment 12

[Dan Erikson]

*** Bug 28573 has been marked as a duplicate of this bug. ***

Comment 13

[Alec Flett]

updating summary so that "port" is in the first 40 chars :)

Comment 14

[Alec Flett]

not a feature per say, taking off feature radar

Comment 15

[Ninoschka Baca]

Adding nbaca as qa contact to check the UI implementation.

Comment 16

[Phil Peterson]

The original description only mentions POP, IMAP and NNTP. We also need to have
user-selectable ports for SMTP. This would get us a functional, if not
beautiful, implementation of Message Submission Protocol (see bug 2679)

Comment 17

[scottputterman]

mass moving to M18 and adding nsbeta3 keyword

Comment 18

[Alec Flett]

this is probably pretty close to done. I'm quite sure it works on POP and almost 
as certain that it works on IMAP. dunno 'bout news

Comment 19

[Alec Flett]

oh my god, this is old. This is already in for beta2.

Comment 20

[Ninoschka Baca]

Build 2000-09-11-08M18: NT4, Linux 6.0, Mac 9.04
The UI ports are there and accept different numeric port settings.
Alec: I don't see an SMTP port setting, should it be there?

Comment 21

[Alec Flett]

oh yeah, I totally forgot about SMTP - yeah, I guess there should be
let's do a different bug
I don't think SMTP on multiple ports is really important for ns6 though, so I'll 
future that bug when you file it :)

Comment 22

[Ninoschka Baca]

Verified Fixed.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56dd923fb685
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14354: Update the search shortcuts icon on state update (https://github.com/mozilla-mobile/fenix/pull/14355)