Closed Bug 1435565 Opened 7 years ago Closed 7 years ago

Activity stream preferences incorrectly webrendered with offset-inline-end: 0

Categories

(Core :: Graphics: WebRender, defect, P1)

60 Branch
x86
macOS
defect

Tracking

()

RESOLVED DUPLICATE of bug 1436420

People

(Reporter: erikharrison, Unassigned)

References

Details

Attachments

(6 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0 Build ID: 20180203100135 Steps to reproduce: Open a new tab. Actual results: Activity Stream preferences are overlayed with the actual content, on the left. The are not interactable. If i hit the cog icon in the upper right, the preferences move to the correct location on the right and can be interacted with. Closing them moves them back to the left Expected results: No preferences visible.
This is probably WONTFIX given bug 1432672.
Has STR: --- → yes
Component: Untriaged → Activity Streams: Newtab
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86
Do you have any custom styling, e.g., userContent.css? As Gingerbread Man mentioned, the preference sidebar is going away with bug 1432672 for Firefox 60.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(erikharrison)
Resolution: --- → WORKSFORME
No, short of enabling webrender Nightly is completely stock. Disabling webrender doesn't make the issue go away.
Flags: needinfo?(erikharrison)
Attached image expected html
If you want to dig in a bit more, from the broken page, what's the html hierarchy to `<div class="sidebar` ? And if you play around with the css rule for `.sidebar.hidden`, does that affect the visibility? In particular `.sidebar` should have a `offset-inline-end: 0` that positions it on the right side of the screen, but your screenshot seems to indicate multiple styles not applying (while some are)…
Attached image With devtools open
Attached image Selected in inspector
Some peculiar behavior (see attachments). Opening dev tools partially resolves issue. Selecting the item in the inspector hides the broken sidebar entirely. Closing devtools makes it reappear. I've captured the outer HTML of the sidebar element, but I used the devtools to do so, so at that point the "busted" side bar was gone. I initially thought the visibility change might be related to the size of the viewport, but changing the window size doesn't alter the presentation of the sidebar, just opening and closing the dev tools
Added source from "view selection source" of the whole page. Note that I can't actually highlight the side bar directly (as stated in the original bug, I cannot interact with the broken sidebar) but the text does highlight when I use Meta+a
Attached file full source.html
I have the same issue, and disabling "offset-inline-end: 0" removes it. In another profile, I can only reproduce it after opening the devtools at the bottom, but closing or moving the devtools won't change. It returns to normal after a refresh when the devtools is not at the bottom. It only happens to me with WebRender enabled. I'm on Arch Linux.
Upon further investigation I am an idiot, and indeed, on my Mac, disabling webrender DOES remove the issue. I can also verify that at least the outer HTML of the sidebar is the same in both webrender enabled and disabled modes.
Status: RESOLVED → REOPENED
Component: Activity Streams: Newtab → Graphics: WebRender
Ever confirmed: true
Product: Firefox → Core
Resolution: WORKSFORME → ---
Summary: activity stream preferences → Activity stream preferences incorrectly webrendered with offset-inline-end: 0
See Also: → 1436420
bug 1436420 has a testcase
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → DUPLICATE
See Also: 1436420
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: