1435687 - Document's element doesn't get focus back after browserAction popup closed.

Status: RESOLVED DUPLICATE of bug 1459560

(WebExtensions :: Frontend, defect, P3)

Description

[ris58h]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180122225545

Steps to reproduce:

- Open a browserAction popup (I use command shortcut, but clicking works too).
- Close it by pressing ESC.
- Try to use, for example, arrow navigation, page shortcuts or try to continue text inputing.


Actual results:

Document's element didn't get focus back.


Expected results:

Document's element should get focus back.
(It works in Chromium)

Comment 1

[Cristina Badescu [:cbadescu], Experiments QA]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180207100355

Hello, 

I have tested this issue on latest Firefox release 58.0.2 and latest Nightly build 60.0a1 and could not reproduce it. I have accessed https://bugzilla.mozilla.org/, clicked "Page actions" menu, click "Esc" key and everything worked as expected: the doorhanger was dismissed and I could focus the page elements, including the "Enter a bug.." field and also I could type.
The same behavior I encountered for "View history, saved bookmarks, and more" button.

Which browserAction popup have you opened when you encountered this issue?

Also, can you please retest this using latest Firefox release and latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile (https://goo.gl/AWo6h8), maybe even safe mode (https://goo.gl/AR5o9d), to eliminate custom settings as a possible cause.

Comment 2

[ris58h]

Hi!

You are right. It seems like it can be reproduced only for web extensions popups that have input elements focused. For example: https://addons.mozilla.org/en-US/firefox/addon/leo-translate/ (it's a simple extension to translate from English to Russian which I use)
I couldn't provide you a screenshot because popus isn't visible when I try to screenshot them. So updated steps to reproduce:
1. Install a web extension that has focused input element in the popup.
2. Open the popup.
3. Press 'Esc' to close the popup.

Comment 3

[Cristina Badescu [:cbadescu], Experiments QA]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180209102946

Hello,

I've retested this issue and I have managed to reproduce it with the provided webextension on latest Firefox release version 58.0.2 and latest Nightly build 60.0a1 (2018-02-09). It seems that after dismissing the doorhanger using the "Esc" key, the page isn't focused anymore.

Indeed, it seems that this issue is reproducible only for webextensions that have input elements focused in their doorhanger, since I didn't manage to reproduce this issue with "Firefox Multi-Account Containers" v5.0.1 (installed from here: https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/).

I also managed to reproduce this issue on Mac 10.11.6, Mac 10.12.6, but didn't reproduce it on Windows 10 x64.

Considering this, I think the suitable component for this is: Toolkit:: WebExtensions: Request Handling.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Focus is going into limbo here.  Bug 1324255 addresses setting focus into the panel when opened, and focus returns to the original document after closing *in some circumstances*.

Comment 5

[Wladimir Palant]

This affects my PfP extension as well (https://addons.mozilla.org/addon/easy-passwords/). When passwords are filled in, the pop-up closes itself. On Chrome, this puts the keyboard focus on the password field and normally you can press Enter to submit the form. In Firefox (58.0 and 60.0a1 2018-02-19 nightly on Linux) the focus is stuck somewhere and an additional click is always required.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Duping to a newer bug with a repro.  At this point it seems to be linux only.