Closed Bug 1435772 Opened 2 years ago Closed 2 years ago

File extensions are stripped out from saved web page source, leading to 404 errors

Categories

(Core :: Networking, defect, P3)

60 Branch
x86_64
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- unaffected
firefox59 --- unaffected
firefox60 --- fixed

People

(Reporter: selim, Assigned: valentin)

References

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Attached file Saved mozilla.org HTML
Steps to reproduce:
1. Go to any web page. I used https://www.mozilla.org/en-US/ as an example but verified this issue on other pages.
2. Save the page by clicking on menu > Save Page As and choosing "Web Page, complete".

pagetitle.html and pagetitle_files are properly created, related files (image, CSS and JS files) are saved properly in the pagetitle_files folder, but their extensions are stripped out in the HTML code. This behaviour breaks the page.

Example:
<link href="mozillaorg_dosyalar/pebbles-bundle" rel="stylesheet" type="text/css">
instead of
<link href="/media/css/pebbles-bundle.css" rel="stylesheet" type="text/css" />

I can confirm that this bug didn't exist 11 days ago.

I'm currently on Nightly build 20180205100240 on Windows 10.
regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=55667c8b5262b5e888a252c457b95989d38c679e&tochange=a20fbbe7b9489c90afddca712925320475083590

Regressed by:a20fbbe7b948	Valentin Gosu — Bug 1432602 - Add nsIFileURLMutator.setFile() r=mayhemer

@:jduell,
Your patch causes the regression, can you look into this?


I was surprised that there was no automatic test on such basic functions.
Blocks: 1432602
Component: File Handling → Networking
Flags: needinfo?(jduell.mcbugs)
Product: Firefox → Core
Assignee: nobody → valentin.gosu
Flags: needinfo?(jduell.mcbugs)
Whiteboard: [necko-triaged]
Priority: -- → P3
https://hg.mozilla.org/integration/mozilla-inbound/rev/73c9ae92a86e0a83491f0dac5a96ee0a5c4e0097
Bug 1435772 - File extensions are stripped out from saved web page source, leading to 404 errors r=me
https://hg.mozilla.org/mozilla-central/rev/73c9ae92a86e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1436589
You need to log in before you can comment on or make changes to this bug.